git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 02/19] apply: a bit more comments on PATH_TO_BE_DELETED

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 13, 2012, 19:32 UTC
Message-ID
<1339615980-19727-3-git-send-email-gitster@pobox.com>
In-Reply-To
<1339615980-19727-1-git-send-email-gitster@pobox.com>

The code is littered with to_be_deleted() whose purpose is not so clear. Describe where it matters. Also remove an extra space before "#define" that snuck in by mistake at 7fac0ee (builtin-apply: keep information about files to be deleted, 2009-04-11).

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/apply.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index be4e3f3..8488c8e 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -2970,9 +2970,15 @@ static struct patch *in_fn_table(const char *name)
  * item->util in the filename table records the status of the path.
  * Usually it points at a patch (whose result records the contents
  * of it after applying it), but it could be PATH_WAS_DELETED for a
- * path that a previously applied patch has already removed.
+ * path that a previously applied patch has already removed, or
+ * PATH_TO_BE_DELETED for a path that a later patch would remove.
+ *
+ * The latter is needed to deal with a case where two paths A and B
+ * are swapped by first renaming A to B and then renaming B to A;
+ * moving A to B should not be prevented due to presense of B as we
+ * will remove it in a later patch.
  */
- #define PATH_TO_BE_DELETED ((struct patch *) -2)
+#define PATH_TO_BE_DELETED ((struct patch *) -2)
 #define PATH_WAS_DELETED ((struct patch *) -1)
 
 static int to_be_deleted(struct patch *patch)
-- 
1.7.11.rc3.30.g3bdace2
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 20 in “"git apply --3way"”
  1. 00/19 "git apply --3way"Junio C Hamano, Jun 13, 2012
  2. 01/19 apply: fix an incomplete comment in check_patch()Junio C Hamano, Jun 13, 2012
  3. 02/19 apply: a bit more comments on PATH_TO_BE_DELETEDJunio C Hamano, Jun 13, 2012
  4. 03/19 apply: clear_image() clears things a bit moreJunio C Hamano, Jun 13, 2012
  5. 04/19 apply: refactor read_file_or_gitlink()Junio C Hamano, Jun 13, 2012
  6. 05/19 apply: factor out checkout_target() helper functionJunio C Hamano, Jun 13, 2012
  7. 06/19 apply: split load_preimage() helper function outJunio C Hamano, Jun 13, 2012
  8. 07/19 apply: refactor "previous patch" logicJunio C Hamano, Jun 13, 2012
  9. 08/19 apply: further split load_preimage()Junio C Hamano, Jun 13, 2012
  10. 09/19 apply: move check_to_create_blob() closer to its sole callerJunio C Hamano, Jun 13, 2012
  11. 10/19 apply: move "already exists" logic to check_to_create()Junio C Hamano, Jun 13, 2012
  12. 11/19 apply: accept -3/--3way command line optionJunio C Hamano, Jun 13, 2012
  13. 12/19 apply: fall back on three-way mergeJunio C Hamano, Jun 13, 2012
  14. 13/19 apply: plug the three-way merge logic inJunio C Hamano, Jun 13, 2012
  15. 14/19 apply: move verify_index_match() higherJunio C Hamano, Jun 13, 2012
  16. 15/19 apply: --3way with add/add conflictJunio C Hamano, Jun 13, 2012
  17. 16/19 apply: register conflicted stages to the indexJunio C Hamano, Jun 13, 2012
  18. 17/19 apply: allow rerere() upon --3way resultsJunio C Hamano, Jun 13, 2012
  19. 18/19 apply: document --3way optionJunio C Hamano, Jun 13, 2012
  20. 19/19 apply --3way: testsJunio C Hamano, Jun 13, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.