git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 17/19] apply: allow rerere() upon --3way results

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 13, 2012, 19:32 UTC
Message-ID
<1339615980-19727-18-git-send-email-gitster@pobox.com>
In-Reply-To
<1339615980-19727-1-git-send-email-gitster@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/apply.c           |  3 +++
 t/t4108-apply-threeway.sh | 25 +++++++++++++++++++++++++
 2 files changed, 28 insertions(+)
diff --git a/builtin/apply.c b/builtin/apply.c
index 8afba92..d12f4f2 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -18,6 +18,7 @@
 #include "parse-options.h"
 #include "xdiff-interface.h"
 #include "ll-merge.h"
+#include "rerere.h"
 
 /*
  *  --check turns on checking that the working tree matches the
@@ -4020,6 +4021,8 @@ static int write_out_results(struct patch *list)
 		for_each_string_list_item(item, &cpath)
 			fprintf(stderr, "U %s\n", item->string);
 		string_list_clear(&cpath, 0);
+
+		rerere(0);
 	}
 
 	return errs;
diff --git a/t/t4108-apply-threeway.sh b/t/t4108-apply-threeway.sh
index 475dfb5..e6d4da6 100755
--- a/t/t4108-apply-threeway.sh
+++ b/t/t4108-apply-threeway.sh
@@ -75,4 +75,29 @@ test_expect_success 'apply with --3way' '
 	test_cmp expect.diff actual.diff
 '
 
+test_expect_success 'apply with --3way with rerere enabled' '
+	git config rerere.enabled true &&
+
+	# Merging side should be similar to applying this patch
+	git diff ...side >P.diff &&
+
+	# The corresponding conflicted merge
+	git reset --hard &&
+	git checkout master^0 &&
+	test_must_fail git merge --no-commit side &&
+
+	# Manually resolve and record the resolution
+	create_file 1 two 3 4 five six 7 >one &&
+	git rerere &&
+	cat one >expect &&
+
+	# should fail to apply
+	git reset --hard &&
+	git checkout master^0 &&
+	test_must_fail git apply --index --3way P.diff &&
+
+	# but rerere should have replayed the recorded resolution
+	test_cmp expect one
+'
+
 test_done
-- 
1.7.11.rc3.30.g3bdace2
Previous: Junio C HamanoNext: Junio C Hamano
Message 18 of 20 in “"git apply --3way"”
  1. 00/19 "git apply --3way"Junio C Hamano, Jun 13, 2012
  2. 01/19 apply: fix an incomplete comment in check_patch()Junio C Hamano, Jun 13, 2012
  3. 02/19 apply: a bit more comments on PATH_TO_BE_DELETEDJunio C Hamano, Jun 13, 2012
  4. 03/19 apply: clear_image() clears things a bit moreJunio C Hamano, Jun 13, 2012
  5. 04/19 apply: refactor read_file_or_gitlink()Junio C Hamano, Jun 13, 2012
  6. 05/19 apply: factor out checkout_target() helper functionJunio C Hamano, Jun 13, 2012
  7. 06/19 apply: split load_preimage() helper function outJunio C Hamano, Jun 13, 2012
  8. 07/19 apply: refactor "previous patch" logicJunio C Hamano, Jun 13, 2012
  9. 08/19 apply: further split load_preimage()Junio C Hamano, Jun 13, 2012
  10. 09/19 apply: move check_to_create_blob() closer to its sole callerJunio C Hamano, Jun 13, 2012
  11. 10/19 apply: move "already exists" logic to check_to_create()Junio C Hamano, Jun 13, 2012
  12. 11/19 apply: accept -3/--3way command line optionJunio C Hamano, Jun 13, 2012
  13. 12/19 apply: fall back on three-way mergeJunio C Hamano, Jun 13, 2012
  14. 13/19 apply: plug the three-way merge logic inJunio C Hamano, Jun 13, 2012
  15. 14/19 apply: move verify_index_match() higherJunio C Hamano, Jun 13, 2012
  16. 15/19 apply: --3way with add/add conflictJunio C Hamano, Jun 13, 2012
  17. 16/19 apply: register conflicted stages to the indexJunio C Hamano, Jun 13, 2012
  18. 17/19 apply: allow rerere() upon --3way resultsJunio C Hamano, Jun 13, 2012
  19. 18/19 apply: document --3way optionJunio C Hamano, Jun 13, 2012
  20. 19/19 apply --3way: testsJunio C Hamano, Jun 13, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.