git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 7/7] clear_ref_cache(): inline function

From
mhagger@alum.mit.edu <mhagger@alum.mit.edu>
Date
Oct 17, 2011, 02:38 UTC
Message-ID
<1318819091-7066-8-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1318819091-7066-1-git-send-email-mhagger@alum.mit.edu>
From: Michael Haggerty <mhagger@alum.mit.edu>

clear_ref_cache() was only called from one place, so inline it there.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 refs.c |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/refs.c b/refs.c
index a888cea..d8a4fa3 100644
--- a/refs.c
+++ b/refs.c
@@ -172,12 +172,6 @@ static void clear_loose_ref_cache(struct ref_cache *refs)
 	refs->did_loose = 0;
 }
 
-static void clear_ref_cache(struct ref_cache *refs)
-{
-	clear_packed_ref_cache(refs);
-	clear_loose_ref_cache(refs);
-}
-
 static struct ref_cache *create_ref_cache(const char *submodule)
 {
 	int len;
@@ -215,7 +209,9 @@ static struct ref_cache *get_ref_cache(const char *submodule)
 
 void invalidate_ref_cache(const char *submodule)
 {
-	clear_ref_cache(get_ref_cache(submodule));
+	struct ref_cache *refs = get_ref_cache(submodule);
+	clear_packed_ref_cache(refs);
+	clear_loose_ref_cache(refs);
 }
 
 static void read_packed_refs(FILE *f, struct ref_array *array)
-- 
1.7.7.rc2
Previous: mhagger@alum.mit.eduNext: Junio C Hamano
Message 8 of 11 in “Provide API to invalidate refs cache”
  1. 0/7 Provide API to invalidate refs cachemhagger@alum.mit.edu, Oct 17, 2011
  2. 1/7 invalidate_ref_cache(): rename function from invalidate_cached_refs()mhagger@alum.mit.edu, Oct 17, 2011
  3. 2/7 invalidate_ref_cache(): take the submodule as parametermhagger@alum.mit.edu, Oct 17, 2011
  4. 3/7 invalidate_ref_cache(): expose this function in the refs APImhagger@alum.mit.edu, Oct 17, 2011
  5. 4/7 clear_ref_cache(): rename parametermhagger@alum.mit.edu, Oct 17, 2011
  6. 5/7 clear_ref_cache(): extract two new functionsmhagger@alum.mit.edu, Oct 17, 2011
  7. 6/7 write_ref_sha1(): only invalidate the loose ref cachemhagger@alum.mit.edu, Oct 17, 2011
  8. 7/7 clear_ref_cache(): inline functionmhagger@alum.mit.edu, Oct 17, 2011
  9. Junio C HamanoOct 17, 2011
  10. Heiko VoigtOct 17, 2011
  11. Michael HaggertyOct 17, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.