git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 2/7] invalidate_ref_cache(): take the submodule as parameter

From
mhagger@alum.mit.edu <mhagger@alum.mit.edu>
Date
Oct 17, 2011, 02:38 UTC
Message-ID
<1318819091-7066-3-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1318819091-7066-1-git-send-email-mhagger@alum.mit.edu>
From: Michael Haggerty <mhagger@alum.mit.edu>

Instead of invalidating the ref cache on an all-or-nothing basis, invalidate the cache for a specific submodule.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 refs.c |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/refs.c b/refs.c
index 02b1ef0..68b73aa 100644
--- a/refs.c
+++ b/refs.c
@@ -202,13 +202,9 @@ static struct ref_cache *get_ref_cache(const char *submodule)
 	return refs;
 }
 
-static void invalidate_ref_cache(void)
+static void invalidate_ref_cache(const char *submodule)
 {
-	struct ref_cache *refs = ref_cache;
-	while (refs) {
-		clear_ref_cache(refs);
-		refs = refs->next;
-	}
+	clear_ref_cache(get_ref_cache(submodule));
 }
 
 static void read_packed_refs(FILE *f, struct ref_array *array)
@@ -1228,7 +1224,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt)
 	ret |= repack_without_ref(refname);
 
 	unlink_or_warn(git_path("logs/%s", lock->ref_name));
-	invalidate_ref_cache();
+	invalidate_ref_cache(NULL);
 	unlock_ref(lock);
 	return ret;
 }
@@ -1527,7 +1523,7 @@ int write_ref_sha1(struct ref_lock *lock,
 		unlock_ref(lock);
 		return -1;
 	}
-	invalidate_ref_cache();
+	invalidate_ref_cache(NULL);
 	if (log_ref_write(lock->ref_name, lock->old_sha1, sha1, logmsg) < 0 ||
 	    (strcmp(lock->ref_name, lock->orig_ref_name) &&
 	     log_ref_write(lock->orig_ref_name, lock->old_sha1, sha1, logmsg) < 0)) {
-- 
1.7.7.rc2
Previous: mhagger@alum.mit.eduNext: mhagger@alum.mit.edu
Message 3 of 11 in “Provide API to invalidate refs cache”
  1. 0/7 Provide API to invalidate refs cachemhagger@alum.mit.edu, Oct 17, 2011
  2. 1/7 invalidate_ref_cache(): rename function from invalidate_cached_refs()mhagger@alum.mit.edu, Oct 17, 2011
  3. 2/7 invalidate_ref_cache(): take the submodule as parametermhagger@alum.mit.edu, Oct 17, 2011
  4. 3/7 invalidate_ref_cache(): expose this function in the refs APImhagger@alum.mit.edu, Oct 17, 2011
  5. 4/7 clear_ref_cache(): rename parametermhagger@alum.mit.edu, Oct 17, 2011
  6. 5/7 clear_ref_cache(): extract two new functionsmhagger@alum.mit.edu, Oct 17, 2011
  7. 6/7 write_ref_sha1(): only invalidate the loose ref cachemhagger@alum.mit.edu, Oct 17, 2011
  8. 7/7 clear_ref_cache(): inline functionmhagger@alum.mit.edu, Oct 17, 2011
  9. Junio C HamanoOct 17, 2011
  10. Heiko VoigtOct 17, 2011
  11. Michael HaggertyOct 17, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.