git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 07/14] is_refname_available(): remove the "quiet" argument

From
Drew Northup <drew.northup@maine.edu>
Date
Oct 13, 2011, 12:41 UTC
Message-ID
<1318509685.7231.6.camel@drew-northup.unet.maine.edu>
In-Reply-To
<1318492715-5931-8-git-send-email-mhagger@alum.mit.edu>
On Thu, 2011-10-13 at 09:58 +0200, mhagger@alum.mit.edu wrote:
> From: Michael Haggerty <mhagger@alum.mit.edu>
> 
> quiet was always set to 0, so get rid of it.  Add a function docstring
> for good measure.

I would like to know if perhaps it was an unfinished project somewhere to propagate the "quiet" option down to this level before removing the function argument. Comments?

> +/*
> + * Return true iff a reference named refname could be created without

Did you really mean "iff" (as in "if and only if") or just plain "if" here?

Show 45 quoted lines
> + * conflicting with the name of an existing reference.  If oldrefname
> + * is non-NULL, ignore potential conflicts with oldrefname (e.g.,
> + * because oldrefname is scheduled for deletion in the same
> + * operation).
> + */
>  static int is_refname_available(const char *refname, const char *oldrefname,
> -				struct ref_array *array, int quiet)
> +				struct ref_array *array)
>  {
>  	int i, namlen = strlen(refname); /* e.g. 'foo/bar' */
>  	for (i = 0; i < array->nr; i++ ) {
> @@ -1062,9 +1069,8 @@ static int is_refname_available(const char *refname, const char *oldrefname,
>  			const char *lead = (namlen < len) ? entry->name : refname;
>  			if (!strncmp(refname, entry->name, cmplen) &&
>  			    lead[cmplen] == '/') {
> -				if (!quiet)
> -					error("'%s' exists; cannot create '%s'",
> -					      entry->name, refname);
> +				error("'%s' exists; cannot create '%s'",
> +				      entry->name, refname);
>  				return 0;
>  			}
>  		}
> @@ -1117,7 +1123,7 @@ static struct ref_lock *lock_ref_sha1_basic(const char *refname,
>  	 * name is a proper prefix of our refname.
>  	 */
>  	if (missing &&
> -	     !is_refname_available(refname, NULL, get_packed_refs(NULL), 0)) {
> +	     !is_refname_available(refname, NULL, get_packed_refs(NULL))) {
>  		last_errno = ENOTDIR;
>  		goto error_return;
>  	}
> @@ -1272,10 +1278,10 @@ int rename_ref(const char *oldrefname, const char *newrefname, const char *logms
>  	if (!symref)
>  		return error("refname %s not found", oldrefname);
>  
> -	if (!is_refname_available(newrefname, oldrefname, get_packed_refs(NULL), 0))
> +	if (!is_refname_available(newrefname, oldrefname, get_packed_refs(NULL)))
>  		return 1;
>  
> -	if (!is_refname_available(newrefname, oldrefname, get_loose_refs(NULL), 0))
> +	if (!is_refname_available(newrefname, oldrefname, get_loose_refs(NULL)))
>  		return 1;
>  
>  	lock = lock_ref_sha1_basic(renamed_ref, NULL, 0, NULL);
-- 
-Drew Northup
________________________________________________
"As opposed to vegetable or mineral error?"
-John Pescatore, SANS NewsBites Vol. 12 Num. 59
Previous: mhagger@alum.mit.eduNext: Junio C Hamano
Message 14 of 28 in “Tidying up references code”
  1. 00/14 Tidying up references codemhagger@alum.mit.edu, Oct 13, 2011
  2. 01/14 cache.h: add comments for git_path() and git_path_submodule()mhagger@alum.mit.edu, Oct 13, 2011
  3. Junio C HamanoOct 13, 2011
  4. 02/14 struct ref_list: document name membermhagger@alum.mit.edu, Oct 13, 2011
  5. Junio C HamanoOct 13, 2011
  6. 03/14 refs.c: rename some local "refname" variablesmhagger@alum.mit.edu, Oct 13, 2011
  7. 04/14 refs: rename some parameters result -> sha1mhagger@alum.mit.edu, Oct 13, 2011
  8. Junio C HamanoOct 13, 2011
  9. 05/14 clear_ref_list(): rename from free_ref_list()mhagger@alum.mit.edu, Oct 13, 2011
  10. Junio C HamanoOct 13, 2011
  11. 06/14 resolve_gitlink_ref(): improve docstringmhagger@alum.mit.edu, Oct 13, 2011
  12. Junio C HamanoOct 13, 2011
  13. 07/14 is_refname_available(): remove the "quiet" argumentmhagger@alum.mit.edu, Oct 13, 2011
  14. Drew NorthupOct 13, 2011
  15. Junio C HamanoOct 13, 2011
  16. Michael HaggertyOct 14, 2011
  17. 08/14 parse_ref_line(): add docstringmhagger@alum.mit.edu, Oct 13, 2011
  18. 09/14 add_ref(): add docstringmhagger@alum.mit.edu, Oct 13, 2011
  19. 10/14 is_dup_ref(): extract function from sort_ref_list()mhagger@alum.mit.edu, Oct 13, 2011
  20. Junio C HamanoOct 13, 2011
  21. 11/14 refs: change signatures of get_packed_refs() and get_loose_refs()mhagger@alum.mit.edu, Oct 13, 2011
  22. 12/14 get_ref_dir(): change signaturemhagger@alum.mit.edu, Oct 13, 2011
  23. 13/14 Pass a (cached_refs *) to the resolve_gitlink_*() functionsmhagger@alum.mit.edu, Oct 13, 2011
  24. 14/14 resolve_gitlink_ref_recursive(): change to work with struct cached_refsmhagger@alum.mit.edu, Oct 13, 2011
  25. t1402-check-ref-format: skip tests of refs beginning with slash on WindowsJohannes Sixt, Oct 13, 2011
  26. Junio C HamanoOct 13, 2011
  27. Junio C HamanoOct 13, 2011
  28. Johannes SixtOct 14, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.