git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 05/14] clear_ref_list(): rename from free_ref_list()

From
mhagger@alum.mit.edu <mhagger@alum.mit.edu>
Date
Oct 13, 2011, 07:58 UTC
Message-ID
<1318492715-5931-6-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1318492715-5931-1-git-send-email-mhagger@alum.mit.edu>
From: Michael Haggerty <mhagger@alum.mit.edu>

Rename the function since it doesn't actually free the array object that is passed to it.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 refs.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/refs.c b/refs.c
index c466fcd..a2e48e4 100644
--- a/refs.c
+++ b/refs.c
@@ -149,7 +149,7 @@ static struct ref_entry *current_ref;
 
 static struct ref_array extra_refs;
 
-static void free_ref_array(struct ref_array *array)
+static void clear_ref_array(struct ref_array *array)
 {
 	int i;
 	for (i = 0; i < array->nr; i++)
@@ -162,14 +162,14 @@ static void free_ref_array(struct ref_array *array)
 static void clear_cached_packed_refs(struct cached_refs *refs)
 {
 	if (refs->did_packed)
-		free_ref_array(&refs->packed);
+		clear_ref_array(&refs->packed);
 	refs->did_packed = 0;
 }
 
 static void clear_cached_loose_refs(struct cached_refs *refs)
 {
 	if (refs->did_loose)
-		free_ref_array(&refs->loose);
+		clear_ref_array(&refs->loose);
 	refs->did_loose = 0;
 }
 
@@ -256,7 +256,7 @@ void add_extra_ref(const char *refname, const unsigned char *sha1, int flag)
 
 void clear_extra_refs(void)
 {
-	free_ref_array(&extra_refs);
+	clear_ref_array(&extra_refs);
 }
 
 static struct ref_array *get_packed_refs(const char *submodule)
-- 
1.7.7.rc2
Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 28 in “Tidying up references code”
  1. 00/14 Tidying up references codemhagger@alum.mit.edu, Oct 13, 2011
  2. 01/14 cache.h: add comments for git_path() and git_path_submodule()mhagger@alum.mit.edu, Oct 13, 2011
  3. Junio C HamanoOct 13, 2011
  4. 02/14 struct ref_list: document name membermhagger@alum.mit.edu, Oct 13, 2011
  5. Junio C HamanoOct 13, 2011
  6. 03/14 refs.c: rename some local "refname" variablesmhagger@alum.mit.edu, Oct 13, 2011
  7. 04/14 refs: rename some parameters result -> sha1mhagger@alum.mit.edu, Oct 13, 2011
  8. Junio C HamanoOct 13, 2011
  9. 05/14 clear_ref_list(): rename from free_ref_list()mhagger@alum.mit.edu, Oct 13, 2011
  10. Junio C HamanoOct 13, 2011
  11. 06/14 resolve_gitlink_ref(): improve docstringmhagger@alum.mit.edu, Oct 13, 2011
  12. Junio C HamanoOct 13, 2011
  13. 07/14 is_refname_available(): remove the "quiet" argumentmhagger@alum.mit.edu, Oct 13, 2011
  14. Drew NorthupOct 13, 2011
  15. Junio C HamanoOct 13, 2011
  16. Michael HaggertyOct 14, 2011
  17. 08/14 parse_ref_line(): add docstringmhagger@alum.mit.edu, Oct 13, 2011
  18. 09/14 add_ref(): add docstringmhagger@alum.mit.edu, Oct 13, 2011
  19. 10/14 is_dup_ref(): extract function from sort_ref_list()mhagger@alum.mit.edu, Oct 13, 2011
  20. Junio C HamanoOct 13, 2011
  21. 11/14 refs: change signatures of get_packed_refs() and get_loose_refs()mhagger@alum.mit.edu, Oct 13, 2011
  22. 12/14 get_ref_dir(): change signaturemhagger@alum.mit.edu, Oct 13, 2011
  23. 13/14 Pass a (cached_refs *) to the resolve_gitlink_*() functionsmhagger@alum.mit.edu, Oct 13, 2011
  24. 14/14 resolve_gitlink_ref_recursive(): change to work with struct cached_refsmhagger@alum.mit.edu, Oct 13, 2011
  25. t1402-check-ref-format: skip tests of refs beginning with slash on WindowsJohannes Sixt, Oct 13, 2011
  26. Junio C HamanoOct 13, 2011
  27. Junio C HamanoOct 13, 2011
  28. Johannes SixtOct 14, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.