git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[CGit] [PATCH v2 2/6] new_filter: correctly initialise all arguments for a new filter

From
Ferry Huberts <mailings@hupie.com>
Date
Mar 4, 2011, 00:31 UTC
Message-ID
<1299198695-23215-3-git-send-email-mailings@hupie.com>
In-Reply-To
<1299198695-23215-1-git-send-email-mailings@hupie.com>
From: Ferry Huberts <ferry.huberts@pelagic.nl>
Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
---
 cgit.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/cgit.c b/cgit.c
index 412fbf0..4440feb 100644
--- a/cgit.c
+++ b/cgit.c
@@ -28,6 +28,7 @@ void add_mimetype(const char *name, const char *value)
 
 struct cgit_filter *new_filter(const char *cmd, int extra_args)
 {
+	int i = 0;
 	struct cgit_filter *f;
 
 	if (!cmd || !cmd[0])
@@ -36,8 +37,10 @@ struct cgit_filter *new_filter(const char *cmd, int extra_args)
 	f = xmalloc(sizeof(struct cgit_filter));
 	f->cmd = xstrdup(cmd);
 	f->argv = xmalloc((2 + extra_args) * sizeof(char *));
-	f->argv[0] = f->cmd;
-	f->argv[1] = NULL;
+	f->argv[i++] = f->cmd;
+	while (i < (2 + extra_args)) {
+	  f->argv[i++] = NULL;
+	}
 	return f;
 }
 
-- 
1.7.4
Previous: Ferry HubertsNext: Ferry Huberts
Message 3 of 7 in “Communicate the repo name to the filter scripts”
  1. Ferry HubertsMar 4, 2011
  2. [CGit] [PATCH v2 1/6] source_filter: fix a memory leakFerry Huberts, Mar 4, 2011
  3. [CGit] [PATCH v2 2/6] new_filter: correctly initialise all arguments for a new filterFerry Huberts, Mar 4, 2011
  4. [CGit] [PATCH v2 3/6] new_filter: determine extra_args from filter typeFerry Huberts, Mar 4, 2011
  5. [CGit] [PATCH v2 4/6] cgit_open_filter: also take the repo as a parameterFerry Huberts, Mar 4, 2011
  6. [CGit] [PATCH v2 5/6] cgit_open_filter: hand down repo configuration to scriptFerry Huberts, Mar 4, 2011
  7. [CGit] [PATCH v2 6/6] filters: document environment variables in filter scriptsFerry Huberts, Mar 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.