[CGit] [PATCH v2 0/6] Communicate the repo name to the filter scripts
- From
Ferry Huberts <mailings@hupie.com>
- Date
- Mar 4, 2011, 00:31 UTC
- Message-ID
- <1299198695-23215-1-git-send-email-mailings@hupie.com>
From: Ferry Huberts <ferry.huberts@pelagic.nl>
Changes compared to v1: - Rewritten to communicate the repo configuration via environment variables
This patch series fixes two bugs, does a cleanup and communicates the repo configuration to the filter scripts.
I have a server setup in which each repo has a trac instance and for the commit filter I really need to know with which repo I'm dealing in order to be able to resolve the #123 ticket numbers into hyperlinks into the correct trac instance.
Patch 0001 fixes a memory leak and can be applied regardless of the other
patches.
Patch 0002 makes sure that all arguments for the filter are correctly
initialised so that the argv[] list is always terminated with a NULL
pointer, which is currently not the case for the source filter.
Patch 0003 does a cleanup by introducing an enum for the filter type so that
the number of extra arguments can be determined in a single place.The other patches implement my desired functionality.
Ferry Huberts (6): source_filter: fix a memory leak new_filter: correctly initialise all arguments for a new filter new_filter: determine extra_args from filter type cgit_open_filter: also take the repo as a parameter cgit_open_filter: hand down repo configuration to script filters: document environment variables in filter scripts
cgit.c | 34 +++++++++--- cgit.h | 6 ++- filters/commit-links.sh | 11 ++++ filters/syntax-highlighting.sh | 11 ++++ shared.c | 110 +++++++++++++++++++++++++++++++++++++++- ui-commit.c | 6 +- ui-repolist.c | 2 +- ui-snapshot.c | 2 +- ui-summary.c | 2 +- ui-tree.c | 4 +- 10 files changed, 169 insertions(+), 19 deletions(-)
-- 1.7.4