git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 07/16] parseopt: OPT_COLUMN to set struct column_layout.mode

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Feb 9, 2011, 12:24 UTC
Message-ID
<1297254284-3729-8-git-send-email-pclouds@gmail.com>
In-Reply-To
<1297254284-3729-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 column.c        |   15 +++++++++++++++
 column.h        |    3 +++
 parse-options.h |    2 ++
 3 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/column.c b/column.c
index 615a698..c08a885 100644
--- a/column.c
+++ b/column.c
@@ -270,3 +270,18 @@ int git_config_column(const char *var, const char *value, int stdout_is_tty)
 
 	return 0;
 }
+
+int parseopt_column_callback(const struct option *opt, const char *arg, int unset)
+{
+	int *mode = opt->value;
+	if (unset) {
+		*mode = COL_MODE_PLAIN;
+		return 0;
+	}
+	if (!arg) {
+		if (!MODE(*mode))
+			*mode |= COL_MODE_COLUMN;
+		return 0;
+	}
+	return parse_column_option(arg, strlen(arg), mode);
+}
diff --git a/column.h b/column.h
index 0749793..99ec848 100644
--- a/column.h
+++ b/column.h
@@ -12,4 +12,7 @@ extern int term_columns(void);
 extern void display_columns(const struct string_list *list, int mode, int width, int padding, const char *indent);
 extern int git_config_column(const char *var, const char *value, int stdout_is_tty);
 
+struct option;
+extern int parseopt_column_callback(const struct option *opt, const char *arg, int unset);
+
 #endif
diff --git a/parse-options.h b/parse-options.h
index 31ec5d2..2fed453 100644
--- a/parse-options.h
+++ b/parse-options.h
@@ -145,6 +145,8 @@ struct option {
 #define OPT_COLOR_FLAG(s, l, v, h) \
 	{ OPTION_CALLBACK, (s), (l), (v), "when", (h), PARSE_OPT_OPTARG, \
 		parse_opt_color_flag_cb, (intptr_t)"always" }
+#define OPT_COLUMN(s, l, v, h) \
+	{ OPTION_CALLBACK, (s), (l), (v), "style", (h), PARSE_OPT_OPTARG, parseopt_column_callback }
 
 
 /* parse_options() will filter out the processed options and leave the
-- 
1.7.2.2
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 8 of 17 in “column output (v2) and git-ls”
  1. 00/16 column output (v2) and git-lsNguyễn Thái Ngọc Duy, Feb 9, 2011
  2. 01/16 Move term_columns() to pager.c and save terminal width before pagerNguyễn Thái Ngọc Duy, Feb 9, 2011
  3. 02/16 Add display_columns() to display in column layoutNguyễn Thái Ngọc Duy, Feb 9, 2011
  4. 03/16 display_columns: add COL_MODE_{COLUMN,ROW} modeNguyễn Thái Ngọc Duy, Feb 9, 2011
  5. 04/16 display_columns: add COL_DENSE to do unequal column layoutNguyễn Thái Ngọc Duy, Feb 9, 2011
  6. 05/16 Add test-column for testing column layoutNguyễn Thái Ngọc Duy, Feb 9, 2011
  7. 06/16 Add core.columnNguyễn Thái Ngọc Duy, Feb 9, 2011
  8. 07/16 parseopt: OPT_COLUMN to set struct column_layout.modeNguyễn Thái Ngọc Duy, Feb 9, 2011
  9. 08/16 help: reuse display_columns() for help -aNguyễn Thái Ngọc Duy, Feb 9, 2011
  10. 09/16 tag: add --columnNguyễn Thái Ngọc Duy, Feb 9, 2011
  11. 10/16 branch: add --columnNguyễn Thái Ngọc Duy, Feb 9, 2011
  12. 11/16 Add ls commandNguyễn Thái Ngọc Duy, Feb 9, 2011
  13. 12/16 ls: add --columnNguyễn Thái Ngọc Duy, Feb 9, 2011
  14. 13/16 ls: add --recursive and turn default to non-recursive modeNguyễn Thái Ngọc Duy, Feb 9, 2011
  15. 14/16 ls: immitate UNIX ls output styleNguyễn Thái Ngọc Duy, Feb 9, 2011
  16. 15/16 ls: strip common directory prefix from outputNguyễn Thái Ngọc Duy, Feb 9, 2011
  17. 16/16 ls: color outputNguyễn Thái Ngọc Duy, Feb 9, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.