git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 12/16] ls: add --column

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Feb 9, 2011, 12:24 UTC
Message-ID
<1297254284-3729-13-git-send-email-pclouds@gmail.com>
In-Reply-To
<1297254284-3729-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/ls-files.c |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/builtin/ls-files.c b/builtin/ls-files.c
index cab7a10..3195f75 100644
--- a/builtin/ls-files.c
+++ b/builtin/ls-files.c
@@ -13,6 +13,7 @@
 #include "parse-options.h"
 #include "resolve-undo.h"
 #include "string-list.h"
+#include "column.h"
 
 static int abbrev;
 static int show_deleted;
@@ -45,8 +46,19 @@ static const char *tag_modified = "";
 static const char *tag_skip_worktree = "";
 static const char *tag_resolve_undo = "";
 
+static struct string_list output;
+static int column_mode;
+
 static void write_name(const char* name, size_t len)
 {
+	/* No quoting in column layout. It will be done by the end. */
+	if (column_mode & COL_MODE) {
+		struct strbuf sb = STRBUF_INIT;
+		strbuf_add(&sb, name, len);
+		string_list_append(&output, strbuf_detach(&sb, NULL));
+		return;
+	}
+
 	write_name_quoted_relative(name, len, prefix, prefix_len, stdout,
 			line_terminator);
 }
@@ -637,6 +649,7 @@ int cmd_ls(int argc, const char **argv, const char *cmd_prefix)
 			DIR_SHOW_IGNORED),
 		OPT_BOOLEAN('k', "killed", &show_killed,
 			"show files on the filesystem that need to be removed"),
+		OPT_COLUMN(0, "column", &column_mode, "show files in columns" ),
 		OPT_END()
 	};
 
@@ -652,6 +665,8 @@ int cmd_ls(int argc, const char **argv, const char *cmd_prefix)
 	if (read_cache() < 0)
 		die("index file corrupt");
 
+	column_mode = core_column;
+
 	argc = parse_options(argc, argv, prefix, builtin_ls_files_options,
 			ls_files_usage, 0);
 
@@ -669,5 +684,6 @@ int cmd_ls(int argc, const char **argv, const char *cmd_prefix)
 		show_cached = 1;
 
 	show_files(&dir);
+	display_columns(&output, column_mode, term_columns(), 2, NULL);
 	return 0;
 }
-- 
1.7.2.2
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 13 of 17 in “column output (v2) and git-ls”
  1. 00/16 column output (v2) and git-lsNguyễn Thái Ngọc Duy, Feb 9, 2011
  2. 01/16 Move term_columns() to pager.c and save terminal width before pagerNguyễn Thái Ngọc Duy, Feb 9, 2011
  3. 02/16 Add display_columns() to display in column layoutNguyễn Thái Ngọc Duy, Feb 9, 2011
  4. 03/16 display_columns: add COL_MODE_{COLUMN,ROW} modeNguyễn Thái Ngọc Duy, Feb 9, 2011
  5. 04/16 display_columns: add COL_DENSE to do unequal column layoutNguyễn Thái Ngọc Duy, Feb 9, 2011
  6. 05/16 Add test-column for testing column layoutNguyễn Thái Ngọc Duy, Feb 9, 2011
  7. 06/16 Add core.columnNguyễn Thái Ngọc Duy, Feb 9, 2011
  8. 07/16 parseopt: OPT_COLUMN to set struct column_layout.modeNguyễn Thái Ngọc Duy, Feb 9, 2011
  9. 08/16 help: reuse display_columns() for help -aNguyễn Thái Ngọc Duy, Feb 9, 2011
  10. 09/16 tag: add --columnNguyễn Thái Ngọc Duy, Feb 9, 2011
  11. 10/16 branch: add --columnNguyễn Thái Ngọc Duy, Feb 9, 2011
  12. 11/16 Add ls commandNguyễn Thái Ngọc Duy, Feb 9, 2011
  13. 12/16 ls: add --columnNguyễn Thái Ngọc Duy, Feb 9, 2011
  14. 13/16 ls: add --recursive and turn default to non-recursive modeNguyễn Thái Ngọc Duy, Feb 9, 2011
  15. 14/16 ls: immitate UNIX ls output styleNguyễn Thái Ngọc Duy, Feb 9, 2011
  16. 15/16 ls: strip common directory prefix from outputNguyễn Thái Ngọc Duy, Feb 9, 2011
  17. 16/16 ls: color outputNguyễn Thái Ngọc Duy, Feb 9, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.