git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 00/21] nd/struct-pathspec v2

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Dec 15, 2010, 15:02 UTC
Message-ID
<1292425376-14550-1-git-send-email-pclouds@gmail.com>
Changes from previous version [1]
 - fixes depth limit and overlapping pathspecs, by checking deepest
   pathspecs first. struct pathspec is now sorted (raw[] untouched)
 - match_pathspec_depth depends on new match_pathspec_item() (a
   clone of match_one(), but takes advantage of struct pathspec)
 - ce_path_match uses struct pathspec
 - strbuf is used instead of fixed length "base" buffer. This
   introduces the weird strbuf_offset() function.
 - never_interesting is disabled if any wildcards is present
 - struct pathspec * == NULL is unacceptable, callers must pass
   non-NULL.
 - a bit more tests
[1] http://mid.gmane.org/1292233616-27692-1-git-send-email-pclouds@gmail.com
Jonathan Nieder (1):
  glossary: define pathspec
Nguyễn Thái Ngọc Duy (20):
  Add struct pathspec
  diff-no-index: use diff_tree_setup_paths()
  Convert struct diff_options to use struct pathspec
  tree_entry_interesting(): remove dependency on struct diff_options
  Move tree_entry_interesting() to tree-walk.c and export it
  diff-tree: convert base+baselen to writable strbuf
  tree_entry_interesting(): refactor into separate smaller functions
  tree_entry_interesting(): support depth limit
  tree_entry_interesting(): fix depth limit with overlapping pathspecs
  tree_entry_interesting(): support wildcard matching
  tree_entry_interesting(): optimize wildcard matching when base is matched
  pathspec: add match_pathspec_depth()
  Convert ce_path_match() to use struct pathspec
  Convert ce_path_match() to use match_pathspec_depth()
  grep: convert to use struct pathspec
  grep: use match_pathspec_depth() for cache/worktree grepping
  strbuf: allow "buf" to point to the middle of the allocated buffer
  grep: use writable strbuf from caller for grep_tree()
  grep: drop pathspec_matches() in favor of tree_entry_interesting()
  t7810: overlapping pathspecs and depth limit
 Documentation/glossary-content.txt |   23 +++
 builtin/diff-files.c               |    2 +-
 builtin/diff.c                     |    4 +-
 builtin/grep.c                     |  197 +++++++-------------------
 builtin/log.c                      |    2 +-
 builtin/update-index.c             |    8 +-
 cache.h                            |   17 ++-
 diff-lib.c                         |   12 ++-
 diff-no-index.c                    |   13 +-
 diff.h                             |    4 +-
 dir.c                              |  151 ++++++++++++++++++++
 dir.h                              |    4 +
 preload-index.c                    |    5 +-
 read-cache.c                       |   25 +---
 revision.c                         |   11 +-
 strbuf.c                           |   36 ++++--
 strbuf.h                           |   10 +-
 t/t4010-diff-pathspec.sh           |   32 ++++
 t/t7810-grep.sh                    |   18 +++
 tree-diff.c                        |  277 +++++++++---------------------------
 tree-walk.c                        |  180 +++++++++++++++++++++++
 tree-walk.h                        |    2 +
 wt-status.c                        |    5 +-
 23 files changed, 615 insertions(+), 423 deletions(-)
-- 
1.7.3.3.476.g10a82
Next: Nguyễn Thái Ngọc Duy
Message 1 of 44 in “nd/struct-pathspec v2”
  1. 00/21 nd/struct-pathspec v2Nguyễn Thái Ngọc Duy, Dec 15, 2010
  2. 01/21 Add struct pathspecNguyễn Thái Ngọc Duy, Dec 15, 2010
  3. 02/21 diff-no-index: use diff_tree_setup_paths()Nguyễn Thái Ngọc Duy, Dec 15, 2010
  4. 03/21 Convert struct diff_options to use struct pathspecNguyễn Thái Ngọc Duy, Dec 15, 2010
  5. 04/21 tree_entry_interesting(): remove dependency on struct diff_optionsNguyễn Thái Ngọc Duy, Dec 15, 2010
  6. 05/21 Move tree_entry_interesting() to tree-walk.c and export itNguyễn Thái Ngọc Duy, Dec 15, 2010
  7. 06/21 glossary: define pathspecNguyễn Thái Ngọc Duy, Dec 15, 2010
  8. 07/21 diff-tree: convert base+baselen to writable strbufNguyễn Thái Ngọc Duy, Dec 15, 2010
  9. 08/21 tree_entry_interesting(): refactor into separate smaller functionsNguyễn Thái Ngọc Duy, Dec 15, 2010
  10. 09/21 tree_entry_interesting(): support depth limitNguyễn Thái Ngọc Duy, Dec 15, 2010
  11. Junio C HamanoJan 28, 2011
  12. Nguyen Thai Ngoc DuyJan 29, 2011
  13. tree_entry_interesting(): with no pathspecs, everything will matchJunio C Hamano, Jan 31, 2011
  14. 10/21 tree_entry_interesting(): fix depth limit with overlapping pathspecsNguyễn Thái Ngọc Duy, Dec 15, 2010
  15. Junio C HamanoDec 16, 2010
  16. Nguyen Thai Ngoc DuyDec 17, 2010
  17. Junio C HamanoDec 17, 2010
  18. Nguyen Thai Ngoc DuyDec 18, 2010
  19. 11/21 tree_entry_interesting(): support wildcard matchingNguyễn Thái Ngọc Duy, Dec 15, 2010
  20. diff-tree doc: correct & remove wrong documentationÆvar Arnfjörð Bjarmason, Feb 4, 2019
  21. Duy NguyenFeb 4, 2019
  22. Junio C HamanoFeb 4, 2019
  23. Ævar Arnfjörð BjarmasonFeb 4, 2019
  24. 12/21 tree_entry_interesting(): optimize wildcard matching when base is matchedNguyễn Thái Ngọc Duy, Dec 15, 2010
  25. 13/21 pathspec: add match_pathspec_depth()Nguyễn Thái Ngọc Duy, Dec 15, 2010
  26. 14/21 Convert ce_path_match() to use struct pathspecNguyễn Thái Ngọc Duy, Dec 15, 2010
  27. Junio C HamanoDec 17, 2010
  28. Nguyen Thai Ngoc DuyDec 17, 2010
  29. 14/21 struct rev_info: convert prune_data to struct pathspecNguyễn Thái Ngọc Duy, Dec 17, 2010
  30. 15/21 Convert ce_path_match() to use struct pathspecNguyễn Thái Ngọc Duy, Dec 17, 2010
  31. Junio C HamanoDec 17, 2010
  32. Nguyen Thai Ngoc DuyDec 17, 2010
  33. Junio C HamanoDec 17, 2010
  34. 15/21 Convert ce_path_match() to use match_pathspec_depth()Nguyễn Thái Ngọc Duy, Dec 15, 2010
  35. 16/21 grep: convert to use struct pathspecNguyễn Thái Ngọc Duy, Dec 15, 2010
  36. 17/21 grep: use match_pathspec_depth() for cache/worktree greppingNguyễn Thái Ngọc Duy, Dec 15, 2010
  37. 18/21 strbuf: allow "buf" to point to the middle of the allocated bufferNguyễn Thái Ngọc Duy, Dec 15, 2010
  38. 19/21 grep: use writable strbuf from caller in grep_tree()Nguyễn Thái Ngọc Duy, Dec 15, 2010
  39. Junio C HamanoDec 17, 2010
  40. Nguyen Thai Ngoc DuyDec 17, 2010
  41. 19/21 grep: use writable strbuf from caller for grep_tree()Nguyễn Thái Ngọc Duy, Dec 17, 2010
  42. 20/21 grep: drop pathspec_matches() in favor of tree_entry_interesting()Nguyễn Thái Ngọc Duy, Dec 15, 2010
  43. 20/21 grep: drop pathspec_matches() in favor of tree_entry_interesting()Nguyễn Thái Ngọc Duy, Dec 17, 2010
  44. 21/21 t7810: overlapping pathspecs and depth limitNguyễn Thái Ngọc Duy, Dec 15, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.