Re: [PATCH] imap-send: link against libcrypto for HMAC and others

From: Diego Elio Pettenò <flameeyes@gmail.com>
Date: Dec 6, 2010, 05:39 UTC
Message-ID: <1291613978.4756.157.camel@yamato.local>
In-Reply-To: <1291613304.3339.12.camel@fixed-disk>

Il giorno lun, 06/12/2010 alle 00.28 -0500, Anders Kaseorg ha scritto:

> This broke the build with NO_OPENSSL=1, so Debian will need to revert
> it:

I'll try a NO_OPENSSL build later on today and see to get it fixed.

> Also, the Makefile already has a NEEDS_CRYPTO_WITH_SSL flag that’s
> automatically set on Darwin, Windows, and MinGW.  We shouldn’t have two
> mechanisms for addressing the same problem; maybe we just need to enable
> the existing flag on more (or all) platforms?

No, these should be different issues; you may have a libssl (which uses libcrypto) requiring libcrypto to be linked in, even if you only use interfaces from libssl (and that's what NEEDS_CRYPTO_WITH_SSL seem to be designed to deal with), but in this case what you have is rather imap-send using the libcrypto interfaces _as well as_ the libssl interfaces.

I have blogged a detailed analysis of the problem, if you wish to see the details:

http://blog.flameeyes.eu/2010/11/26/it-s-not-all-gold-that-shines-why-underlinking-is-a-bad-thing

-- 
Diego Elio Pettenò — “Flameeyes”
http://blog.flameeyes.eu/

If you found a .asc file in this mail and know not what it is,
it's a GnuPG digital signature: http://www.gnupg.org/