git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] imap-send: link against libcrypto for HMAC and others

From
Diego Elio Pettenò <flameeyes@gmail.com>
Date
Nov 24, 2010, 20:03 UTC
Message-ID
<1290629033-20566-1-git-send-email-flameeyes@gmail.com>
In-Reply-To
<7vwro2sd83.fsf@alter.siamese.dyndns.org>

When using stricter linkers, such as GNU gold or Darwin ld, transitive dependencies are not counted towards symbol resolution. If we don't link imap-send to libcrypto, we'll have undefined references to the HMAC_*, EVP_* and ERR_* functions families.

Signed-off-by: Diego Elio Pettenò <flameeyes@gmail.com>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 1f1ce04..c8377d4 100644
--- a/Makefile
+++ b/Makefile
@@ -1927,7 +1927,7 @@ git-%$X: %.o $(GITLIBS)
 
 git-imap-send$X: imap-send.o $(GITLIBS)
 	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
-		$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)
+		$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)
 
 git-http-fetch$X: revision.o http.o http-walker.o http-fetch.o $(GITLIBS)
 	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
-- 
1.7.3.2
Previous: Junio C HamanoNext: Anders Kaseorg
Message 3 of 10 in “imap-send: link against libcrypto for HMAC and others”
  1. imap-send: link against libcrypto for HMAC and othersDiego Elio Pettenò, Nov 24, 2010
  2. Junio C HamanoNov 24, 2010
  3. imap-send: link against libcrypto for HMAC and othersDiego Elio Pettenò, Nov 24, 2010
  4. Anders KaseorgDec 6, 2010
  5. Diego Elio PettenòDec 6, 2010
  6. Jonathan NiederDec 6, 2010
  7. Junio C HamanoDec 6, 2010
  8. Jared HanceDec 8, 2010
  9. Junio C HamanoDec 8, 2010
  10. Anders KaseorgDec 8, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.