git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH/RFC] gitweb: Go to DONE_REQUEST rather than DONE_GITWEB in die_error

From
Jakub Narebski <jnareb@gmail.com>
Date
Nov 25, 2010, 22:15 UTC
Message-ID
<1290723308-21685-1-git-send-email-jnareb@gmail.com>

End the request after die_error finishes, rather than exiting gitweb instance (perhaps wrapped like in ModPerl::Registry or gitweb.psgi case).

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Should bring no differences except for running gitweb in persistent
environments natively, without wrapping; currently only FastCGI is
supported.
 gitweb/gitweb.perl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 1d94718..bcd7c8a 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1156,6 +1156,7 @@ sub run {
 
 		run_request();
 
+	DONE_REQUEST:
 		$post_dispatch_hook->()
 			if $post_dispatch_hook;
 		$first_request = 0;
@@ -3679,7 +3680,7 @@ EOF
 	print "</div>\n";
 
 	git_footer_html();
-	goto DONE_GITWEB
+	goto DONE_REQUEST
 		unless ($opts{'-error_handler'});
 }
 
-- 
1.7.3
Message 1 of 1 in “gitweb: Go to DONE_REQUEST rather than DONE_GITWEB in die_error”
  1. gitweb: Go to DONE_REQUEST rather than DONE_GITWEB in die_errorJakub Narebski, Nov 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.