threads / rfc / 25841

RFC patchgitweb: Go to DONE_REQUEST rather than DONE_GITWEB in die_error

Subject: [PATCH/RFC] gitweb: Go to DONE_REQUEST rather than DONE_GITWEB in die_error

## tl;dr

One message between Nov 25, 2010 and Nov 25, 2010. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Jakub Narebski· Nov 25, 2010, 22:15 UTC · lore

End the request after die_error finishes, rather than exiting gitweb instance (perhaps wrapped like in ModPerl::Registry or gitweb.psgi case).

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Should bring no differences except for running gitweb in persistent
environments natively, without wrapping; currently only FastCGI is
supported.
 gitweb/gitweb.perl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Show changes to gitweb/gitweb.perl +2 −1
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 1d94718..bcd7c8a 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1156,6 +1156,7 @@ sub run {
 
 		run_request();
 
+	DONE_REQUEST:
 		$post_dispatch_hook->()
 			if $post_dispatch_hook;
 		$first_request = 0;
@@ -3679,7 +3680,7 @@ EOF
 	print "</div>\n";
 
 	git_footer_html();
-	goto DONE_GITWEB
+	goto DONE_REQUEST
 		unless ($opts{'-error_handler'});
 }
 
-- 
1.7.3

← back to recent threads