[PATCH v3 6/9] http-push: Normalise directory names when pushing to some WebDAV servers
- From
Tay Ray Chuan <rctay89@gmail.com>
- Date
- Nov 25, 2010, 08:21 UTC
- Message-ID
- <1290673270-4284-7-git-send-email-rctay89@gmail.com>
- In-Reply-To
- <1290673270-4284-6-git-send-email-rctay89@gmail.com>
Fix a bug when pushing to WebDAV servers which do not use a trailing slash for collection names. The previous implementation fails to see that the requested resource "refs/" is the same resource as "refs" and loads every reference twice (once for refs/ and once for refs).
This implementation normalises every collection name by appending a trailing slash if necessary.
This can be tested with old versions of Apache (such as the WebDAV server of GMX, Apache 2.0.63).
Based-on-patch-by: Gabriel Corona <gabriel.corona@enst-bretagne.fr> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com> --- http-push.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/http-push.c b/http-push.c index c9bcd11..565e580 100644 --- a/http-push.c +++ b/http-push.c @@ -1090,6 +1090,10 @@ static void handle_remote_ls_ctx(struct xml_ctx *ctx, int tag_closed) if (tag_closed) { if (!strcmp(ctx->name, DAV_PROPFIND_RESP) && ls->dentry_name) { if (ls->dentry_flags & IS_DIR) { + + /* ensure collection names end with slash */ + str_end_url_with_slash(ls->dentry_name, &ls->dentry_name); + if (ls->flags & PROCESS_DIRS) { ls->userFunc(ls); }
-- 1.7.3.2.495.gc7b3f