git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 4/9] url: add str wrapper for end_url_with_slash()

From
Tay Ray Chuan <rctay89@gmail.com>
Date
Nov 25, 2010, 08:21 UTC
Message-ID
<1290673270-4284-5-git-send-email-rctay89@gmail.com>
In-Reply-To
<1290673270-4284-4-git-send-email-rctay89@gmail.com>
Helped-by: Johnathan Nieder <jrnieder@gmail.com>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
Changed from v2: removed pointer check before free(), as suggested by Johnathan.
 url.c |    7 +++++++
 url.h |    1 +
 2 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/url.c b/url.c
index 7cebc64..6a54959 100644
--- a/url.c
+++ b/url.c
@@ -132,3 +132,10 @@ void end_url_with_slash(struct strbuf *buf, const char *url)
 	if (buf->len && buf->buf[buf->len - 1] != '/')
 		strbuf_addstr(buf, "/");
 }
+
+void str_end_url_with_slash(const char *url, char **dest) {
+	struct strbuf buf = STRBUF_INIT;
+	end_url_with_slash(&buf, url);
+	free(*dest);
+	*dest = strbuf_detach(&buf, NULL);
+}
diff --git a/url.h b/url.h
index 8cb74d4..7100e32 100644
--- a/url.h
+++ b/url.h
@@ -8,5 +8,6 @@ extern char *url_decode_parameter_name(const char **query);
 extern char *url_decode_parameter_value(const char **query);
 
 extern void end_url_with_slash(struct strbuf *buf, const char *url);
+extern void str_end_url_with_slash(const char *url, char **dest);
 
 #endif /* URL_H */
-- 
1.7.3.2.495.gc7b3f
Previous: Tay Ray ChuanNext: Tay Ray Chuan
Message 7 of 12 in “Re: [PATCH v2 3/7] url: add str wrapper for end_url_with_slash()”
  1. Jonathan NiederNov 22, 2010
  2. Tay Ray ChuanNov 22, 2010
  3. 0/9 http: end urls with slashTay Ray Chuan, Nov 25, 2010
  4. 1/9 t5550-http-fetch: add missing '&&'Tay Ray Chuan, Nov 25, 2010
  5. 2/9 t5550-http-fetch: add test for http-fetchTay Ray Chuan, Nov 25, 2010
  6. 3/9 shift end_url_with_slash() from http.[ch] to url.[ch]Tay Ray Chuan, Nov 25, 2010
  7. 4/9 url: add str wrapper for end_url_with_slash()Tay Ray Chuan, Nov 25, 2010
  8. 5/9 http-backend: use end_url_with_slash()Tay Ray Chuan, Nov 25, 2010
  9. 6/9 http-push: Normalise directory names when pushing to some WebDAV serversTay Ray Chuan, Nov 25, 2010
  10. 7/9 http-push: check path length before using itTay Ray Chuan, Nov 25, 2010
  11. 8/9 http-push: add trailing slash at arg-parse time, instead of later onTay Ray Chuan, Nov 25, 2010
  12. 9/9 http-fetch: rework url handlingTay Ray Chuan, Nov 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.