git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[WIP PATCH 19/22] Make graph_next_line external to other part of git

From
Bo Yang <struggleyb.nku@gmail.com>
Date
Jul 24, 2010, 15:13 UTC
Message-ID
<1279984434-28933-20-git-send-email-struggleyb.nku@gmail.com>
In-Reply-To
<1279984434-28933-1-git-send-email-struggleyb.nku@gmail.com>
We will use it in line level log output.
Signed-off-by: Bo Yang <struggleyb.nku@gmail.com>
---
 graph.c |   14 +-------------
 graph.h |   10 ++++++++++
 2 files changed, 11 insertions(+), 13 deletions(-)
diff --git a/graph.c b/graph.c
index ac7c605..824e055 100644
--- a/graph.c
+++ b/graph.c
@@ -4,21 +4,9 @@
 #include "graph.h"
 #include "diff.h"
 #include "revision.h"
-
 /* Internal API */
 
 /*
- * Output the next line for a graph.
- * This formats the next graph line into the specified strbuf.  It is not
- * terminated with a newline.
- *
- * Returns 1 if the line includes the current commit, and 0 otherwise.
- * graph_next_line() will return 1 exactly once for each time
- * graph_update() is called.
- */
-static int graph_next_line(struct git_graph *graph, struct strbuf *sb);
-
-/*
  * Output a padding line in the graph.
  * This is similar to graph_next_line().  However, it is guaranteed to
  * never print the current commit line.  Instead, if the commit line is
@@ -1143,7 +1131,7 @@ static void graph_output_collapsing_line(struct git_graph *graph, struct strbuf
 		graph_update_state(graph, GRAPH_PADDING);
 }
 
-static int graph_next_line(struct git_graph *graph, struct strbuf *sb)
+int graph_next_line(struct git_graph *graph, struct strbuf *sb)
 {
 	switch (graph->state) {
 	case GRAPH_PADDING:
diff --git a/graph.h b/graph.h
index b82ae87..5b3f059 100644
--- a/graph.h
+++ b/graph.h
@@ -32,6 +32,16 @@ void graph_update(struct git_graph *graph, struct commit *commit);
  */
 int graph_is_commit_finished(struct git_graph const *graph);
 
+/*
+ * Output the next line for a graph.
+ * This formats the next graph line into the specified strbuf.  It is not
+ * terminated with a newline.
+ *
+ * Returns 1 if the line includes the current commit, and 0 otherwise.
+ * graph_next_line() will return 1 exactly once for each time
+ * graph_update() is called.
+ */
+int graph_next_line(struct git_graph *graph, struct strbuf *sb);
 
 /*
  * graph_show_*: helper functions for printing to stdout
-- 
1.7.0.2.273.gc2413.dirty
Previous: Bo YangNext: Bo Yang
Message 21 of 24 in “Some updates since v3”
  1. 00/22 Some updates since v3Bo Yang, Jul 24, 2010
  2. 01/22 parse-options: enhance STOP_AT_NON_OPTIONBo Yang, Jul 24, 2010
  3. 02/22 parse-options: add two helper functionsBo Yang, Jul 24, 2010
  4. 03/22 Add the basic data structure for line level historyBo Yang, Jul 24, 2010
  5. 04/22 Refactor parse_locBo Yang, Jul 24, 2010
  6. 05/22 Parse the -L optionsBo Yang, Jul 24, 2010
  7. 06/22 Export three functions from diff.cBo Yang, Jul 24, 2010
  8. 07/22 Add range clone functionsBo Yang, Jul 24, 2010
  9. 08/22 map/take range to the parent of commitsBo Yang, Jul 24, 2010
  10. 09/22 Print the line logBo Yang, Jul 24, 2010
  11. 10/22 Hook line history into cmd_log, ensuring a topo-ordered walkBo Yang, Jul 24, 2010
  12. 11/22 Add --full-line-diff optionBo Yang, Jul 24, 2010
  13. 12/22 Add tests for line history browserBo Yang, Jul 24, 2010
  14. Thomas RastJul 24, 2010
  15. 13/22 Document line history browserBo Yang, Jul 24, 2010
  16. 14/22 Make rewrite_parents public to other part of gitBo Yang, Jul 24, 2010
  17. 15/22 Add parent rewriting to line history browserBo Yang, Jul 24, 2010
  18. 16/22 Add --graph prefix before line history outputBo Yang, Jul 24, 2010
  19. 17/22 Add test cases for '--graph' of line level logBo Yang, Jul 24, 2010
  20. 18/22 a fast fixBo Yang, Jul 24, 2010
  21. 19/22 Make graph_next_line external to other part of gitBo Yang, Jul 24, 2010
  22. 20/22 some changesBo Yang, Jul 24, 2010
  23. 21/22 commit parents prunning codeBo Yang, Jul 24, 2010
  24. 22/22 A merge should not be printed anywayBo Yang, Jul 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.