git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[WIP PATCH 11/22] Add --full-line-diff option

From
Bo Yang <struggleyb.nku@gmail.com>
Date
Jul 24, 2010, 15:13 UTC
Message-ID
<1279984434-28933-12-git-send-email-struggleyb.nku@gmail.com>
In-Reply-To
<1279984434-28933-1-git-send-email-struggleyb.nku@gmail.com>

Always print the interesting ranges even if the current commit does not change any line of it.

Signed-off-by: Bo Yang <struggleyb.nku@gmail.com>
---
 builtin/log.c |    3 +++
 line.c        |   11 +++++++++--
 revision.h    |    3 ++-
 3 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/builtin/log.c b/builtin/log.c
index 0aa982b..9799c1c 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -86,6 +86,7 @@ static void cmd_log_init(int argc, const char **argv, const char *prefix,
 {
 	int i;
 	int decoration_given = 0;
+	static int full_line_diff = 0;
 	struct userformat_want w;
 	const char *path = NULL, *pathspec = NULL;
 	static struct diff_line_range *range = NULL, *r = NULL;
@@ -93,6 +94,7 @@ static void cmd_log_init(int argc, const char **argv, const char *prefix,
 	static struct line_opt_callback_data line_cb = {&range, &ctx, NULL};
 	static const struct option options[] = {
 		OPT_CALLBACK('L', NULL, &line_cb, "n,m", "Process only line range n,m, counting from 1", log_line_range_callback),
+		OPT_BOOLEAN(0, "full-line-diff", &full_line_diff, "Always print the interesting range even if the current commit does not change any line of it"),
 		OPT_END()
 	};
 
@@ -225,6 +227,7 @@ parse_done:
 	/* Test whether line level history is asked for */
 	if (range && range->nr > 0) {
 		setup_line(rev, range);
+		rev->full_line_diff = full_line_diff;
 	}
 }
 
diff --git a/line.c b/line.c
index c17659a..5317fe5 100644
--- a/line.c
+++ b/line.c
@@ -1116,6 +1116,13 @@ static void diff_flush_filepair(struct rev_info *rev, struct diff_line_range *ra
 	 * no sensible rang->pair since there is no diff run.
 	 */
 	if (one == NULL) {
+		if (rev->full_line_diff) {
+			chunk.two = two->data;
+			chunk.two_end = two->data + two->size;
+			chunk.ltwo = 1;
+			chunk.range = range;
+			diff_flush_chunks(&rev->diffopt, &chunk);
+		}
 		return;
 	}
 
@@ -1226,7 +1233,7 @@ static void line_log_flush(struct rev_info *rev, struct commit *c)
 		return flush_nontrivial_merge(rev, nontrivial);
 
 	while (range) {
-		if (range->diff)
+		if (range->diff || (range->nr && rev->full_line_diff))
 			diff_flush_filepair(rev, range);
 		range = range->next;
 	}
@@ -1261,7 +1268,7 @@ int cmd_line_log_walk(struct rev_info *rev)
 			assign_parents_range(rev, commit);
 		}
 
-		if (commit->object.flags & NEED_PRINT) {
+		if (commit->object.flags & NEED_PRINT || rev->full_line_diff) {
 			line_log_flush(rev, commit);
 		}
 
diff --git a/revision.h b/revision.h
index 2627ec4..e4b6adf 100644
--- a/revision.h
+++ b/revision.h
@@ -72,7 +72,8 @@ struct rev_info {
 			bisect:1,
 			ancestry_path:1,
 			first_parent_only:1,
-			line_level_traverse:1;
+			line_level_traverse:1,
+			full_line_diff:1;
 
 	/* Diff flags */
 	unsigned int	diff:1,
-- 
1.7.0.2.273.gc2413.dirty
Previous: Bo YangNext: Bo Yang
Message 12 of 24 in “Some updates since v3”
  1. 00/22 Some updates since v3Bo Yang, Jul 24, 2010
  2. 01/22 parse-options: enhance STOP_AT_NON_OPTIONBo Yang, Jul 24, 2010
  3. 02/22 parse-options: add two helper functionsBo Yang, Jul 24, 2010
  4. 03/22 Add the basic data structure for line level historyBo Yang, Jul 24, 2010
  5. 04/22 Refactor parse_locBo Yang, Jul 24, 2010
  6. 05/22 Parse the -L optionsBo Yang, Jul 24, 2010
  7. 06/22 Export three functions from diff.cBo Yang, Jul 24, 2010
  8. 07/22 Add range clone functionsBo Yang, Jul 24, 2010
  9. 08/22 map/take range to the parent of commitsBo Yang, Jul 24, 2010
  10. 09/22 Print the line logBo Yang, Jul 24, 2010
  11. 10/22 Hook line history into cmd_log, ensuring a topo-ordered walkBo Yang, Jul 24, 2010
  12. 11/22 Add --full-line-diff optionBo Yang, Jul 24, 2010
  13. 12/22 Add tests for line history browserBo Yang, Jul 24, 2010
  14. Thomas RastJul 24, 2010
  15. 13/22 Document line history browserBo Yang, Jul 24, 2010
  16. 14/22 Make rewrite_parents public to other part of gitBo Yang, Jul 24, 2010
  17. 15/22 Add parent rewriting to line history browserBo Yang, Jul 24, 2010
  18. 16/22 Add --graph prefix before line history outputBo Yang, Jul 24, 2010
  19. 17/22 Add test cases for '--graph' of line level logBo Yang, Jul 24, 2010
  20. 18/22 a fast fixBo Yang, Jul 24, 2010
  21. 19/22 Make graph_next_line external to other part of gitBo Yang, Jul 24, 2010
  22. 20/22 some changesBo Yang, Jul 24, 2010
  23. 21/22 commit parents prunning codeBo Yang, Jul 24, 2010
  24. 22/22 A merge should not be printed anywayBo Yang, Jul 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.