Re: [PATCH GSoC 2/3] git-instaweb: Configure it to work with a global server root and projects list

From: Dévai Tamás <devait@vnet.hu>
Date: May 16, 2010, 00:16 UTC
Message-ID: <1273969019.1169.16.camel@localhost.localdomain>
In-Reply-To: <1273953520-25990-2-git-send-email-pavan.sss1991@gmail.com>

> +# Default is /usr/share/gitweb
> +test -z "$root" && root='/usr/share/gitweb'

Just one question: what happens, when one installs to /usr/local (or any other directory) instead of /usr? I'd use the $(gitwebdir) variable from the Makefile as default, such as

  # if installed, it doesn't need further configuration (module_path)
  test -z "$httpd" && httpd='lighttpd -f'
  
-+# Default is /usr/share/gitweb
-+test -z "$root" && root='/usr/share/gitweb'
++# Default is @@gitwebdir@@
++test -z "$root" && root='@@gitwebdir@@'
 +
  # any untaken local port will do...
  test -z "$port" && port=1234

and in the Makefile

         sed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \
             -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \
             -e 's/@@NO_CURL@@/$(NO_CURL)/g' \
++           -e 's|@@gitwebdir@@|$(gitwebdir)|g' \
 -           -e '/@@GITWEB_CGI@@/r gitweb/gitweb.cgi' \
 -           -e '/@@GITWEB_CGI@@/d' \
 -           -e '/@@GITWEB_CSS@@/r $(GITWEB_CSS)' \

Hope that you find it reasonable. -- Dévai Tamás