[PATCH 5/6] git_mkstemps_mode: don't set errno to EINVAL on exit.

From: Matthieu Moy <matthieu.moy@imag.fr>
Date: Feb 22, 2010, 22:32 UTC
Message-ID: <1266877936-13537-6-git-send-email-Matthieu.Moy@imag.fr>
In-Reply-To: <1266597207-32036-1-git-send-email-Matthieu.Moy@imag.fr>

When reaching the end of git_mkstemps_mode, at least one call to open() has been done, and errno has been set accordingly. Setting errno is therefore not necessary, and actually harmfull since callers can't distinguish e.g. permanent failure from ENOENT, which can just mean that we need to create the containing directory.

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 path.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/path.c b/path.c
index 925039a..6f44921 100644
--- a/path.c
+++ b/path.c
@@ -222,7 +222,6 @@ int git_mkstemps_mode(char *pattern, int suffix_len, int mode)
 	}
 	/* We return the null string if we can't find a unique file name.  */
 	pattern[0] = '\0';
-	errno = EINVAL;
 	return -1;
 }

-- 
1.7.0.54.gb6a04.dirty