git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/4] Allow Git repositories to be shared using POSIX ACLs

From
Matthieu Moy <matthieu.moy@imag.fr>
Date
Feb 19, 2010, 16:33 UTC
Message-ID
<1266597207-32036-1-git-send-email-Matthieu.Moy@imag.fr>
I talked about the problem earlier:
http://thread.gmane.org/gmane.comp.version-control.git/136720

In short: if a user wants to share a git repository using POSIX filesystem ACLs, it seems everything works except pack file creation. The problem is that we create the file with a mode 0600, i.e. no permission for group, but the semantics of ACL is that this group permission is used as ACL umask when the file has ACLs (don't ask me why, I never understood the rational, but that's how it works).

Instead, if we let the umask do its job at the time of file creation, then the pack file is created with the correct permission bits and ACLs, and we don't need to chmod it after the fact. This is what this patch serie does.

The test-case is really weak: ideally, we should have a real test with several users interacting. But that's hardly scriptable in a portable way, so the only testcase I added relies on getfacl and "ls -l" to find out if the result is correct. However, I did some manual testing, and as far as I can say, Git works very well with ACLs with this patch.

Next: Matthieu Moy
Message 1 of 18 in “Allow Git repositories to be shared using POSIX ACLs”
  1. 0/4 Allow Git repositories to be shared using POSIX ACLsMatthieu Moy, Feb 19, 2010
  2. 1/4 Add a testcase for ACL with restrictive umask.Matthieu Moy, Feb 19, 2010
  3. 2/4 Move gitmkstemps to path.cMatthieu Moy, Feb 19, 2010
  4. 3/4 git_mkstemp_mode, xmkstemp_mode: variants of gitmkstemps with mode argument.Matthieu Moy, Feb 19, 2010
  5. 4/4 Use git_mkstemp_mode and xmkstemp_mode in odb_mkstemp, not chmod later.Matthieu Moy, Feb 19, 2010
  6. Junio C HamanoFeb 20, 2010
  7. Matthieu MoyFeb 22, 2010
  8. Junio C HamanoFeb 22, 2010
  9. Junio C HamanoFeb 22, 2010
  10. Matthieu MoyFeb 22, 2010
  11. Junio C HamanoFeb 19, 2010
  12. 0/6 Allow Git repositories to be shared using POSIX ACLsMatthieu Moy, Feb 22, 2010
  13. 1/6 Add a testcase for ACL with restrictive umask.Matthieu Moy, Feb 22, 2010
  14. 2/6 Move gitmkstemps to path.cMatthieu Moy, Feb 22, 2010
  15. 3/6 git_mkstemp_mode, xmkstemp_mode: variants of gitmkstemps with mode argument.Matthieu Moy, Feb 22, 2010
  16. 4/6 Use git_mkstemp_mode and xmkstemp_mode in odb_mkstemp, not chmod later.Matthieu Moy, Feb 22, 2010
  17. 5/6 git_mkstemps_mode: don't set errno to EINVAL on exit.Matthieu Moy, Feb 22, 2010
  18. 6/6 Use git_mkstemp_mode instead of plain mkstemp to create object filesMatthieu Moy, Feb 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.