git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/8 v6] gitweb: add a get function to compliment print_sort_th

From
Jakub Narebski <jnareb@gmail.com>
Date
Jan 30, 2010, 22:30 UTC
Message-ID
<1264890645-28310-7-git-send-email-jnareb@gmail.com>
In-Reply-To
<1264890645-28310-1-git-send-email-jnareb@gmail.com>
From: John 'Warthog9' Hawley <warthog9@kernel.org>

This adds a get function (named format_sort_th) for print_sort_th, so that the basic function can be used outside of their straight printing operation.

Signed-off-by: John 'Warthog9' Hawley <warthog9@kernel.org>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Changes from version from 'Gitweb caching v5' and
  git://git.kernel.org/pub/scm/git/warthog9/gitweb.git gitweb-ml-v5
* Change function name from get_* to format_*, following gitweb
  subroutine naming convention.
 gitweb/gitweb.perl |   17 ++++++++++++-----
 1 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index debaf55..466fa8a 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4347,17 +4347,24 @@ sub fill_project_list_info {
 # print 'sort by' <th> element, generating 'sort by $name' replay link
 # if that order is not selected
 sub print_sort_th {
+	print format_sort_th(@_);
+}
+
+sub format_sort_th {
 	my ($name, $order, $header) = @_;
+	my $sort_th = "";
 	$header ||= ucfirst($name);
 
 	if ($order eq $name) {
-		print "<th>$header</th>\n";
+		$sort_th .= "<th>$header</th>\n";
 	} else {
-		print "<th>" .
-		      $cgi->a({-href => href(-replay=>1, order=>$name),
-		               -class => "header"}, $header) .
-		      "</th>\n";
+		$sort_th .= "<th>" .
+		            $cgi->a({-href => href(-replay=>1, order=>$name),
+		                     -class => "header"}, $header) .
+		            "</th>\n";
 	}
+
+	return $sort_th;
 }
 
 sub git_project_list_body {
-- 
1.6.6.1
Previous: Junio C HamanoNext: Jakub Narebski
Message 8 of 14 in “Miscelanous gitweb improvements from 'Gitweb caching v5' by J.H.”
  1. 0/8 Miscelanous gitweb improvements from 'Gitweb caching v5' by J.H.Jakub Narebski, Jan 30, 2010
  2. 1/8 gitweb: Make running t9501 test with '--debug' reliable and usableJakub Narebski, Jan 30, 2010
  3. 2/8 gitweb: Load checkingJakub Narebski, Jan 30, 2010
  4. 3/8 gitweb: Makefile improvementsJakub Narebski, Jan 30, 2010
  5. 4/8 gitweb: Check that $site_header etc. are defined before using themJakub Narebski, Jan 30, 2010
  6. 5/8 gitweb: add a get function to compliment print_local_timeJakub Narebski, Jan 30, 2010
  7. Junio C HamanoJan 31, 2010
  8. 6/8 gitweb: add a get function to compliment print_sort_thJakub Narebski, Jan 30, 2010
  9. 7/8 gitweb: Add optional extra parameter to die_error, for extended explanationJakub Narebski, Jan 30, 2010
  10. 8/8 gitweb: Add an option to force version matchJakub Narebski, Jan 30, 2010
  11. J.H.Feb 2, 2010
  12. Jakub NarebskiFeb 2, 2010
  13. Junio C HamanoFeb 2, 2010
  14. Junio C HamanoFeb 2, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.