From: Jakub Narebski Date: Sat, 30 Jan 2010 22:30:43 GMT Subject: [PATCH 6/8 v6] gitweb: add a get function to compliment print_sort_th Message-ID: <1264890645-28310-7-git-send-email-jnareb@gmail.com> In-Reply-To: <1264890645-28310-1-git-send-email-jnareb@gmail.com> From: John 'Warthog9' Hawley This adds a get function (named format_sort_th) for print_sort_th, so that the basic function can be used outside of their straight printing operation. Signed-off-by: John 'Warthog9' Hawley Signed-off-by: Jakub Narebski --- Changes from version from 'Gitweb caching v5' and git://git.kernel.org/pub/scm/git/warthog9/gitweb.git gitweb-ml-v5 * Change function name from get_* to format_*, following gitweb subroutine naming convention. gitweb/gitweb.perl | 17 ++++++++++++----- 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index debaf55..466fa8a 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -4347,17 +4347,24 @@ sub fill_project_list_info { # print 'sort by' element, generating 'sort by $name' replay link # if that order is not selected sub print_sort_th { + print format_sort_th(@_); +} + +sub format_sort_th { my ($name, $order, $header) = @_; + my $sort_th = ""; $header ||= ucfirst($name); if ($order eq $name) { - print "$header\n"; + $sort_th .= "$header\n"; } else { - print "" . - $cgi->a({-href => href(-replay=>1, order=>$name), - -class => "header"}, $header) . - "\n"; + $sort_th .= "" . + $cgi->a({-href => href(-replay=>1, order=>$name), + -class => "header"}, $header) . + "\n"; } + + return $sort_th; } sub git_project_list_body { -- 1.6.6.1