git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git branch -D: give a better error message when lockfile creation fails

From
Miklos Vajna <vmiklos@frugalware.org>
Date
Sep 26, 2009, 00:06 UTC
Message-ID
<1253923602-17818-1-git-send-email-vmiklos@frugalware.org>

Previously the old error message just told the user that it was not possible to delete the ref from the packed-refs file. Give instructions on how to resolve the problem.

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
 refs.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/refs.c b/refs.c
index 24865cf..221d49c 100644
--- a/refs.c
+++ b/refs.c
@@ -972,8 +972,10 @@ static int repack_without_ref(const char *refname)
 	if (!found)
 		return 0;
 	fd = hold_lock_file_for_update(&packlock, git_path("packed-refs"), 0);
-	if (fd < 0)
+	if (fd < 0) {
+		unable_to_lock_index_die(git_path("packed-refs"), errno);
 		return error("cannot delete '%s' from packed refs", refname);
+	}
 
 	for (list = packed_ref_list; list; list = list->next) {
 		char line[PATH_MAX + 100];
-- 
1.6.5.rc1.44.ga1675.dirty
Next: Jeff King
Message 1 of 9 in “git branch -D: give a better error message when lockfile creation fails”
  1. git branch -D: give a better error message when lockfile creation failsMiklos Vajna, Sep 26, 2009
  2. Jeff KingSep 26, 2009
  3. git branch -D: give a better error message when lockfile creation failsMiklos Vajna, Sep 26, 2009
  4. Shawn O. PearceSep 26, 2009
  5. Matthieu MoySep 26, 2009
  6. git branch -D: give a better error message when lockfile creation failsMiklos Vajna, Sep 26, 2009
  7. Jeff KingSep 27, 2009
  8. Miklos VajnaSep 27, 2009
  9. Matthieu MoySep 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.