[PATCHv4 2/5] am: suppress apply errors when using 3-way

From: Stephen Boyd <bebarino@gmail.com>
Date: Jun 16, 2009, 22:32 UTC
Message-ID: <1245191581-11127-3-git-send-email-bebarino@gmail.com>
In-Reply-To: <1245191581-11127-2-git-send-email-bebarino@gmail.com>

git-am with 3-way outputs errors when applying, even though the 3-way will usually be successful. We suppress these errors from git-apply because they are not "true" errors until the 3-way has been attempted.

Signed-off-by: Stephen Boyd <bebarino@gmail.com>
---

Seems to me like we should always suppress these errors if we're falling back to 3-way. So I've removed the test for GIT_QUIET and pushed this earlier in the series.

 git-am.sh |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/git-am.sh b/git-am.sh
index 578780b..e26c54a 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -502,7 +502,14 @@ do
 
 	case "$resolved" in
 	'')
-		eval 'git apply '"$git_apply_opt"' --index "$dotest/patch"'
+		# When we are allowed to fall back to 3-way later, don't give
+		# false errors during the initial attempt.
+		squelch=
+		if test "$threeway" = t
+		then
+			squelch='>/dev/null 2>&1 '
+		fi
+		eval "git apply $squelch$git_apply_opt"' --index "$dotest/patch"'
 		apply_status=$?
 		;;
 	t)

-- 
1.6.3.2.306.g4f4fa