git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 1/4] t4150: test applying with a newline in subject

From
Stephen Boyd <bebarino@gmail.com>
Date
Jun 16, 2009, 02:05 UTC
Message-ID
<1245117905-19351-2-git-send-email-bebarino@gmail.com>
In-Reply-To
<1245117905-19351-1-git-send-email-bebarino@gmail.com>

Commit 4b7cc26 (git-am: use printf instead of echo on user-supplied strings, 2007-05-25) fixed a bug where subjects with newlines would cause git-am to echo multiple lines when it says "Applying: <subject>".

This test ensures that fix stays valid.
Signed-off-by: Stephen Boyd <bebarino@gmail.com>
---
 t/t4150-am.sh |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/t/t4150-am.sh b/t/t4150-am.sh
index d6ebbae..51c369a 100755
--- a/t/t4150-am.sh
+++ b/t/t4150-am.sh
@@ -305,4 +305,12 @@ test_expect_success 'am into an unborn branch' '
 	test "z$result" = "z$(git rev-parse first^{tree})"
 '
 
+test_expect_success 'am newline in subject' '
+	git checkout first &&
+	test_tick &&
+	sed -e "s/second/second \\\n foo/" patch1 > patchnl &&
+	git am < patchnl > output.out 2>&1 &&
+	grep "^Applying: second \\\n foo$" output.out
+'
+
 test_done
-- 
1.6.3.2.306.g4f4fa
Previous: Stephen BoydNext: Stephen Boyd
Message 2 of 18 in “[PATCHv3 0/4] Teach shell scripts to be quiet”
  1. Stephen BoydJun 16, 2009
  2. 1/4 t4150: test applying with a newline in subjectStephen Boyd, Jun 16, 2009
  3. 2/4 git-sh-setup: introduce say() for quiet optionsStephen Boyd, Jun 16, 2009
  4. 3/4 submodule, repack: migrate to git-sh-setup's say()Stephen Boyd, Jun 16, 2009
  5. 4/4 am, rebase: teach quiet optionStephen Boyd, Jun 16, 2009
  6. Junio C HamanoJun 16, 2009
  7. Stephen BoydJun 16, 2009
  8. Junio C HamanoJun 16, 2009
  9. Junio C HamanoJun 16, 2009
  10. Stephen BoydJun 16, 2009
  11. Johannes SixtJun 16, 2009
  12. 0/5 Teach shell scripts to be quietStephen Boyd, Jun 16, 2009
  13. 1/5 t4150: test applying with a newline in subjectStephen Boyd, Jun 16, 2009
  14. 2/5 am: suppress apply errors when using 3-wayStephen Boyd, Jun 16, 2009
  15. 3/5 git-sh-setup: introduce say() for quiet optionsStephen Boyd, Jun 16, 2009
  16. 4/5 submodule, repack: migrate to git-sh-setup's say()Stephen Boyd, Jun 16, 2009
  17. 5/5 am, rebase: teach quiet optionStephen Boyd, Jun 16, 2009
  18. 6/5 stash: teach quiet optionStephen Boyd, Jun 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.