[JGIT PATCH 06/11] Use getCachedBytes in IndexPack to avoid an unnecessary copy
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Apr 29, 2009, 18:54 UTC
- Message-ID
- <1241031288-23437-7-git-send-email-spearce@spearce.org>
- In-Reply-To
- <1241031288-23437-6-git-send-email-spearce@spearce.org>
This is deep within the library code, where we know we won't overwrite the cached buffer for an object. Using getCachedBytes saves a full array copy while fixing a thin pack and appending whole objects. The extra copy isn't so much an issue of CPU time as it is about creating unnecessary temporary garbage for the GC to clean up.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org> ---
Unchanged.
.../src/org/spearce/jgit/transport/IndexPack.java | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java b/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java index eecad9c..eeeae16 100644 --- a/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java +++ b/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java @@ -500,7 +500,7 @@ private void fixThinPack(final ProgressMonitor progress) throws IOException { missing.add(baseId); continue; } - final byte[] data = ldr.getBytes(); + final byte[] data = ldr.getCachedBytes(); final int typeCode = ldr.getType(); final PackedObjectInfo oe;
-- 1.6.3.rc3.199.g24398