[PATCH 3/5] Fix GIT_CEILING_DIRECTORIES on Windows
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Feb 7, 2009, 15:08 UTC
- Message-ID
- <1234019311-6449-4-git-send-email-j6t@kdbg.org>
- In-Reply-To
- <1234019311-6449-3-git-send-email-j6t@kdbg.org>
From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Using git with GIT_CEILING_DIRECTORIES crashed on Windows due to a failed assertion in normalize_absolute_path(): This function expects absolute paths to start with a slash, while on Windows they can start with a drive letter or a backslash.
This fixes it by using the alternative, normalize_path_copy() instead, which can handle Windows-style paths just fine.
Secondly, the portability macro PATH_SEP is used instead of expecting colons to be used as path list delimiter.
The test script t1504 is also changed to help MSYS's bash recognize some program arguments as path list. (MSYS's bash must translate POSIX-style path lists to Windows-style path lists, and the heuristic did not catch some cases.)
Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> Signed-off-by: Johannes Sixt <j6t@kdbg.org> --- I have adjusted the patch to fit into the series. I modified the commit message to pretend that the goal was to fix a feature instead of the test case ;) Hope that is fine with you.
-- Hannes
path.c | 11 ++++++----- t/t1504-ceiling-dirs.sh | 6 +++--- 2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/path.c b/path.c index d0a3519..dc3807a 100644 --- a/path.c +++ b/path.c @@ -524,15 +524,16 @@ int longest_ancestor_length(const char *path, const char *prefix_list) return -1; for (colon = ceil = prefix_list; *colon; ceil = colon+1) { - for (colon = ceil; *colon && *colon != ':'; colon++); + for (colon = ceil; *colon && *colon != PATH_SEP; colon++); len = colon - ceil; if (len == 0 || len > PATH_MAX || !is_absolute_path(ceil)) continue; strlcpy(buf, ceil, len+1); - len = normalize_absolute_path(buf, buf); - /* Strip "trailing slashes" from "/". */ - if (len == 1) - len = 0; + if (normalize_path_copy(buf, buf) < 0) + continue; + len = strlen(buf); + if (len > 0 && buf[len-1] == '/') + buf[--len] = '\0'; if (!strncmp(path, buf, len) && path[len] == '/' && diff --git a/t/t1504-ceiling-dirs.sh b/t/t1504-ceiling-dirs.sh index 91b704a..e377d48 100755 --- a/t/t1504-ceiling-dirs.sh +++ b/t/t1504-ceiling-dirs.sh @@ -93,13 +93,13 @@ GIT_CEILING_DIRECTORIES="$TRASH_ROOT/subdi" test_prefix subdir_ceil_at_subdi_slash "sub/dir/" -GIT_CEILING_DIRECTORIES="foo:$TRASH_ROOT/sub" +GIT_CEILING_DIRECTORIES="/foo:$TRASH_ROOT/sub" test_fail second_of_two -GIT_CEILING_DIRECTORIES="$TRASH_ROOT/sub:bar" +GIT_CEILING_DIRECTORIES="$TRASH_ROOT/sub:/bar" test_fail first_of_two -GIT_CEILING_DIRECTORIES="foo:$TRASH_ROOT/sub:bar" +GIT_CEILING_DIRECTORIES="/foo:$TRASH_ROOT/sub:/bar" test_fail second_of_three
-- 1.6.1.297.g9b01e