[PATCH 1/5] Make test-path-utils more robust against incorrect use
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Feb 7, 2009, 15:08 UTC
- Message-ID
- <1234019311-6449-2-git-send-email-j6t@kdbg.org>
- In-Reply-To
- <1234019311-6449-1-git-send-email-j6t@kdbg.org>
Previously, this test utility happily returned with exit code 0 if garbage was thrown at it. Now it reports failure if an unknown function name was given on the command line.
Signed-off-by: Johannes Sixt <j6t@kdbg.org> --- test-path-utils.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/test-path-utils.c b/test-path-utils.c index 2c0f5a3..7e6fc8d 100644 --- a/test-path-utils.c +++ b/test-path-utils.c @@ -7,6 +7,7 @@ int main(int argc, char **argv) int rv = normalize_absolute_path(buf, argv[2]); assert(strlen(buf) == rv); puts(buf); + return 0; } if (argc >= 2 && !strcmp(argv[1], "make_absolute_path")) { @@ -15,12 +16,16 @@ int main(int argc, char **argv) argc--; argv++; } + return 0; } if (argc == 4 && !strcmp(argv[1], "longest_ancestor_length")) { int len = longest_ancestor_length(argv[2], argv[3]); printf("%d\n", len); + return 0; } - return 0; + fprintf(stderr, "%s: unknown function name: %s\n", argv[0], + argv[1] ? argv[1] : "(there was none)"); + return 1; }
-- 1.6.1.297.g9b01e