git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] Make test-path-utils more robust against incorrect use

From
Johannes Sixt <j6t@kdbg.org>
Date
Feb 7, 2009, 15:08 UTC
Message-ID
<1234019311-6449-2-git-send-email-j6t@kdbg.org>
In-Reply-To
<1234019311-6449-1-git-send-email-j6t@kdbg.org>

Previously, this test utility happily returned with exit code 0 if garbage was thrown at it. Now it reports failure if an unknown function name was given on the command line.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 test-path-utils.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/test-path-utils.c b/test-path-utils.c
index 2c0f5a3..7e6fc8d 100644
--- a/test-path-utils.c
+++ b/test-path-utils.c
@@ -7,6 +7,7 @@ int main(int argc, char **argv)
 		int rv = normalize_absolute_path(buf, argv[2]);
 		assert(strlen(buf) == rv);
 		puts(buf);
+		return 0;
 	}
 
 	if (argc >= 2 && !strcmp(argv[1], "make_absolute_path")) {
@@ -15,12 +16,16 @@ int main(int argc, char **argv)
 			argc--;
 			argv++;
 		}
+		return 0;
 	}
 
 	if (argc == 4 && !strcmp(argv[1], "longest_ancestor_length")) {
 		int len = longest_ancestor_length(argv[2], argv[3]);
 		printf("%d\n", len);
+		return 0;
 	}
 
-	return 0;
+	fprintf(stderr, "%s: unknown function name: %s\n", argv[0],
+		argv[1] ? argv[1] : "(there was none)");
+	return 1;
 }
-- 
1.6.1.297.g9b01e
Previous: Johannes SixtNext: Johannes Sixt
Message 17 of 26 in “fix crash in path.c on Windows”
  1. fix crash in path.c on WindowsRené Scharfe, Feb 4, 2009
  2. Junio C HamanoFeb 4, 2009
  3. Johannes SixtFeb 5, 2009
  4. René ScharfeFeb 5, 2009
  5. Johannes SixtFeb 5, 2009
  6. Robin RosenbergFeb 5, 2009
  7. fix t1504 on WindowsRené Scharfe, Feb 5, 2009
  8. Johannes SixtFeb 6, 2009
  9. Johannes SchindelinFeb 6, 2009
  10. Johannes SixtFeb 6, 2009
  11. Johannes SchindelinFeb 6, 2009
  12. Johannes SixtFeb 6, 2009
  13. René ScharfeFeb 6, 2009
  14. Johannes SixtFeb 6, 2009
  15. René ScharfeFeb 6, 2009
  16. 0/5 Consolidate path normalization functionsJohannes Sixt, Feb 7, 2009
  17. 1/5 Make test-path-utils more robust against incorrect useJohannes Sixt, Feb 7, 2009
  18. 2/5 Move sanitary_path_copy() to path.c and rename it to normalize_path_copy()Johannes Sixt, Feb 7, 2009
  19. 3/5 Fix GIT_CEILING_DIRECTORIES on WindowsJohannes Sixt, Feb 7, 2009
  20. 4/5 Test and fix normalize_path_copy()Johannes Sixt, Feb 7, 2009
  21. 5/5 Remove unused normalize_absolute_path()Johannes Sixt, Feb 7, 2009
  22. Robin RosenbergFeb 8, 2009
  23. Johannes SixtFeb 8, 2009
  24. René ScharfeFeb 8, 2009
  25. Johannes SixtFeb 8, 2009
  26. René ScharfeFeb 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.