git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] git notes show: handle empty notes gracefully

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Feb 6, 2009, 16:17 UTC
Message-ID
<1233937075-31194-1-git-send-email-git@drmicha.warpmail.net>

"git notes show" barks when there is no note to show. This introduces a test (yes, a test!) and, in a second round, reacts more gracefully to empty notes and adjust the expected test output accordingly.

Note that in both cases (before/after the patch) the return code is non-zero: It's 128 in the ungraceful case, 1 when "dieing gracefully", uhm...

The main achivement in v2 is the correction of typos in the commit messages and comments, as well as the addition of proper s-o-b (son of a...) lines.

Additionally, v2 incorporates input from the two J's. We test explicitly for return code 1 now.

Michael J Gruber (2):
  git notes show: test empty notes
  handle empty notes gracefully
 git-notes.sh     |    2 ++
 t/t3301-notes.sh |    5 +++++
 2 files changed, 7 insertions(+), 0 deletions(-)
Next: Michael J Gruber
Message 1 of 4 in “git notes show: handle empty notes gracefully”
  1. 0/2 git notes show: handle empty notes gracefullyMichael J Gruber, Feb 6, 2009
  2. 1/2 git notes show: test empty notesMichael J Gruber, Feb 6, 2009
  3. 2/2 handle empty notes gracefullyMichael J Gruber, Feb 6, 2009
  4. Thomas RastFeb 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.