threads / patch / 17619

v2, 2 partsgit notes show: handle empty notes gracefully

Subject: [PATCH v2 0/2] git notes show: handle empty notes gracefully

## tl;dr

4 messages between Feb 6, 2009 and Feb 14, 2009. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Michael J Gruber· Feb 6, 2009, 16:17 UTC · lore

"git notes show" barks when there is no note to show. This introduces a test (yes, a test!) and, in a second round, reacts more gracefully to empty notes and adjust the expected test output accordingly.

Note that in both cases (before/after the patch) the return code is non-zero: It's 128 in the ungraceful case, 1 when "dieing gracefully", uhm...

The main achivement in v2 is the correction of typos in the commit messages and comments, as well as the addition of proper s-o-b (son of a...) lines.

Additionally, v2 incorporates input from the two J's. We test explicitly for return code 1 now.

Michael J Gruber (2):
  git notes show: test empty notes
  handle empty notes gracefully

 git-notes.sh     |    2 ++
 t/t3301-notes.sh |    5 +++++
 2 files changed, 7 insertions(+), 0 deletions(-)

Michael J Gruber· Feb 6, 2009, 16:17 UTC · re: Michael J Gruber · lore

[PATCH v2 1/2] git notes show: test empty notes

Add a test for the handling of empty notes by "git notes show".

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
 t/t3301-notes.sh |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

Show changes to t/t3301-notes.sh +5 −0

diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
index 9393a25..7ef1c29 100755
--- a/t/t3301-notes.sh
+++ b/t/t3301-notes.sh
@@ -35,6 +35,11 @@ test_expect_success 'need valid notes ref' '
 	! MSG=2 GIT_NOTES_REF='/' git notes show
 '
 
+# 1 indicates caught gracefully by die, 128 means git-show barked
+test_expect_failure 'handle empty notes gracefully' '
+	git notes show ; test 1 = $?
+'
+
 test_expect_success 'create notes' '
 	git config core.notesRef refs/notes/commits &&
 	MSG=b1 git notes edit &&

-- 
1.6.1.2.253.ga34a

Michael J Gruber· Feb 6, 2009, 16:17 UTC · re: Michael J Gruber · lore

[PATCH v2 2/2] handle empty notes gracefully

Currently, git-notes barks when asked to show an empty (i.e. non-existing) note. Change this to explicitly say there is none.

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
 git-notes.sh     |    2 ++
 t/t3301-notes.sh |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)

Show changes to 2 files +3 −1

git-notes.sh, t/t3301-notes.sh

diff --git a/git-notes.sh b/git-notes.sh
index bfdbaa8..9cbad02 100755
--- a/git-notes.sh
+++ b/git-notes.sh
@@ -58,6 +58,8 @@ edit)
 		"$GIT_NOTES_REF" $NEW_HEAD $CURRENT_HEAD
 ;;
 show)
+	git rev-parse -q --verify "$GIT_NOTES_REF":$COMMIT > /dev/null ||
+		die "No note for commit $COMMIT."
 	git show "$GIT_NOTES_REF":$COMMIT
 ;;
 *)
diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
index 7ef1c29..ff4ea05 100755
--- a/t/t3301-notes.sh
+++ b/t/t3301-notes.sh
@@ -36,7 +36,7 @@ test_expect_success 'need valid notes ref' '
 '
 
 # 1 indicates caught gracefully by die, 128 means git-show barked
-test_expect_failure 'handle empty notes gracefully' '
+test_expect_success 'handle empty notes gracefully' '
 	git notes show ; test 1 = $?
 '

-- 
1.6.1.2.253.ga34a

Thomas Rast· Feb 14, 2009, 17:46 UTC · re: Michael J Gruber · lore

Re: [PATCH v2 0/2] git notes show: handle empty notes gracefully

Michael J Gruber wrote:

> Michael J Gruber (2):
>   git notes show: test empty notes
>   handle empty notes gracefully

Tested-by: Thomas Rast <trast@student.ethz.ch>

The previous message was especially annoying because it would fire up the pager on narrow terminals.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch