Re: [PATCH] git-filter-branch: Add an example on how to remove empty commits

From: Sam Vilain <sam@vilain.net>
Date: Oct 30, 2008, 00:39 UTC
Message-ID: <1225327159.21951.15.camel@maia.lan>
In-Reply-To: <1225326833-15210-1-git-send-email-pasky@suse.cz>

On Wed, 2008-10-29 at 17:33 -0700, Petr Baudis wrote:

Show 8 quoted lines

> +To remove commits that are empty (do not introduce any change):
> +
> +------------------------------------------------------------------------------
> +git rev-list HEAD | while read c; do [ -n "$(git diff-tree --root $c)" ] || echo $c; done > revs
> +
> +git filter-branch --commit-filter '
> +  if grep -q "$GIT_COMMIT" '"$(pwd)/"revs';
> +  then

Why not put the git diff-tree in the commit filter?

Is this tested? It doesn't look like it does what the comment says... surely you have to compare with the previous commit, not the null commit?

Sam.