git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] test-lib: fix color reset in say_color()

From
Miklos Vajna <vmiklos@frugalware.org>
Date
Oct 9, 2008, 22:07 UTC
Message-ID
<1223590030-7464-1-git-send-email-vmiklos@frugalware.org>

When executing a single test with colors enabled, the cursor was not set back to the previous one, and you had to hit an extra enter to get it back.

Work around this problem by calling 'tput sgr0' before printing the final newline.

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---

Actually I'm not 100% sure about how many users are affected. I have a black background in konsole with white letters, and after the test I get a green cursor, and once I hit enter, I get the white one back.

 t/test-lib.sh |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index e2b106c..fb89741 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -112,8 +112,9 @@ if test -n "$color"; then
 			*) test -n "$quiet" && return;;
 		esac
 		shift
-		echo "* $*"
+		printf "* $*"
 		tput sgr0
+		echo
 		)
 	}
 else
-- 
1.6.0.2
Next: Jakub Narebski
Message 1 of 3 in “test-lib: fix color reset in say_color()”
  1. test-lib: fix color reset in say_color()Miklos Vajna, Oct 9, 2008
  2. Jakub NarebskiOct 10, 2008
  3. Jeff KingOct 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.