threads / patch / 15845

patchtest-lib: fix color reset in say_color()

Subject: [PATCH] test-lib: fix color reset in say_color()

## tl;dr

3 messages between Oct 9, 2008 and Oct 11, 2008. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Miklos Vajna· Oct 9, 2008, 22:07 UTC · lore

When executing a single test with colors enabled, the cursor was not set back to the previous one, and you had to hit an extra enter to get it back.

Work around this problem by calling 'tput sgr0' before printing the final newline.

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---

Actually I'm not 100% sure about how many users are affected. I have a black background in konsole with white letters, and after the test I get a green cursor, and once I hit enter, I get the white one back.

 t/test-lib.sh |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Show changes to t/test-lib.sh +2 −1

diff --git a/t/test-lib.sh b/t/test-lib.sh
index e2b106c..fb89741 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -112,8 +112,9 @@ if test -n "$color"; then
 			*) test -n "$quiet" && return;;
 		esac
 		shift
-		echo "* $*"
+		printf "* $*"
 		tput sgr0
+		echo
 		)
 	}
 else

-- 
1.6.0.2

Jakub Narebski· Oct 10, 2008, 09:30 UTC · re: Miklos Vajna · lore

Re: [PATCH] test-lib: fix color reset in say_color()

Miklos Vajna <vmiklos@frugalware.org> writes:

Show 13 quoted lines

> When executing a single test with colors enabled, the cursor was not set
> back to the previous one, and you had to hit an extra enter to get it
> back.
> 
> Work around this problem by calling 'tput sgr0' before printing the
> final newline.
> 
> Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
> ---
> 
> Actually I'm not 100% sure about how many users are affected. I have a
> black background in konsole with white letters, and after the test I get
> a green cursor, and once I hit enter, I get the white one back.

I also had this very minor irritation that cursor retained color of last line till enter (or IIRC any key which moved cursor). I use ordinary xterm from X.Org 6.8.2(213).

-- 
Jakub Narebski
Poland
ShadeHawk on #git

Jeff King· Oct 11, 2008, 02:00 UTC · re: Miklos Vajna · lore

Re: [PATCH] test-lib: fix color reset in say_color()

On Fri, Oct 10, 2008 at 12:07:10AM +0200, Miklos Vajna wrote:

> Actually I'm not 100% sure about how many users are affected. I have a
> black background in konsole with white letters, and after the test I get
> a green cursor, and once I hit enter, I get the white one back.

I think my comment is way late, as this has already been applied, but I think this is definitely the right thing to do. We are very careful to use the same pattern (color reset before newline) in the C code.

-Peff