[PATCH 0/2] * SUBJECT HERE *

From: Thomas Rast <trast@student.ethz.ch>
Date: Aug 29, 2008, 13:42 UTC
Message-ID: <1220017369-32637-1-git-send-email-trast@student.ethz.ch>
In-Reply-To: <20080829081654.GA6680@yp-box.dyndns.org>

Eric Wong wrote.

> > So should we just change all "unknown foo" tests to verify that 'git
> > svn info' errors out too?
>
> Yes, I see no reason to differ from plain svn here.

This starts getting more complicated at every turn. The included mini-series (probably textually depends on the other 6 patches though) "fixes" this.

HOWEVER: Subversion itself broke compatibility here.  In 1.4:

  $ svn info new; echo $?
  new:  (Not a versioned resource)

Note the extra linebreak and successful exit. Current git-svn precisely matches this output. In 1.5, it's different:

  $ svn info new; echo $?
  svn: 'new' is not under version control
  1

While it is of course up to you what you would like to do (and modulo test_must_fail, 2/2 can still be used to fix the tests if you decide to reject 1/2), I suggest changing to 1.5 behaviour. exit(1) is the sane thing to do in this case, and that is already breaking bit-for-bit compatibility with SVN 1.4, so we might as well adopt the new error message. Of course this prevents us from comparing the output literally in the tests, so I settled for a slightly weaker check: failure status and mention of the filename.

Unfortunately this does raise the question whether the URL-encoding issue treated in the other series is in fact a similar incompatibility between 1.4 and 1.5, not a (minor but long-standing) bug in git-svn.

- Thomas

 git-svn.perl            |    4 +-
 t/t9119-git-svn-info.sh |   73 ++++++++++++++++-------------------------------
 2 files changed, 27 insertions(+), 50 deletions(-)

[PATCH 0/2] *** SUBJECT HERE ***

[PATCH 0/2] * SUBJECT HERE *