git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/6] 'git svn info' fixes

From
Thomas Rast <trast@student.ethz.ch>
Date
Aug 26, 2008, 19:32 UTC
Message-ID
<1219779157-31602-1-git-send-email-trast@student.ethz.ch>

Actually, I only wanted to do 5/6 (git svn info: make info relative to the current directory). This seemed like a fairly simple change, see the corresponding mail.

However, I also wanted to provide tests, and that's where the fun started. Turns out t9119-git-svn-info.sh is currently quite broken. 1-4 just fix the tests; a brief summary:

[1/6] git svn info: tests: let 'init' test run with SVN 1.5
  The tests do not report any problems with 1.5.
[2/6] git svn info: tests: do not use set -e
  No idea how 'set -e' ever got in there; it completely breaks the
  test script in case of an error.
[3/6] git svn info: tests: use test_cmp instead of git-diff
  git-diff does not correctly report the exit status (IIRC that is
  caused by the pager setup code?), which used to hide a lot of
  errors.
[4/6] git svn info: tests: fix ptouch argument order in setup
  Swapped arguments caused ptouch to fail and tests to break.

Yes, I'm just whoring commit karma here, so feel free to squash these four into one if you like it better that way.

After these, 22 of 37 tests (all except --url, plus all unknown files) fail. Most of them are caused by 'git svn info' not URL-encoding the URL and Repository fields in the output, as SVN does. 6/6 fixes this.

However, the unknown files tests still fail, simply because 'svn info' itself fails on untracked files. It would be great if someone who is still running SVN 1.4 could check whether that has been a bug in git-svn all along, or is actually a behaviour change on the part of SVN.

Oh, and let's hope I did the splitting right this time :-)
 git-svn.perl            |   30 +++++++++++--
 t/t9119-git-svn-info.sh |  102 ++++++++++++++++++++++++++---------------------
 2 files changed, 82 insertions(+), 50 deletions(-)
Next: Thomas Rast
Message 1 of 17 in “'git svn info' fixes”
  1. 0/6 'git svn info' fixesThomas Rast, Aug 26, 2008
  2. 1/6 git svn info: tests: let 'init' test run with SVN 1.5Thomas Rast, Aug 26, 2008
  3. 2/6 git svn info: tests: do not use set -eThomas Rast, Aug 26, 2008
  4. 3/6 git svn info: tests: use test_cmp instead of git-diffThomas Rast, Aug 26, 2008
  5. 4/6 git svn info: tests: fix ptouch argument order in setupThomas Rast, Aug 26, 2008
  6. 5/6 git svn info: make info relative to the current directoryThomas Rast, Aug 26, 2008
  7. 6/6 git svn info: always quote URLs in 'info' outputThomas Rast, Aug 26, 2008
  8. Eric WongAug 27, 2008
  9. Eric WongAug 27, 2008
  10. Thomas RastAug 28, 2008
  11. Eric WongAug 29, 2008
  12. 0/2 *** SUBJECT HERE ***Thomas Rast, Aug 29, 2008
  13. 1/2 git-svn: match SVN 1.5 behaviour of info' on unknown itemThomas Rast, Aug 29, 2008
  14. 2/2 git-svn: fix 'info' tests for unknown itemsThomas Rast, Aug 29, 2008
  15. Eric WongAug 30, 2008
  16. Thomas RastSep 1, 2008
  17. Eric WongSep 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.