git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git svn: should not display zombie externals

From
Eddy Petrișor <eddy.petrisor@gmail.com>
Date
Aug 29, 2008, 00:02 UTC
Message-ID
<1219968179-14156-1-git-send-email-eddy.petrisor@gmail.com>
In-Reply-To
<60381eeb0808281702q3dc7543enff2b35ebbcc80d08@mail.gmail.com>

subversion does not process in any way empty svn:externals properties and doesn't list them in any way; git svn externals shouldn't do that either

Signed-off-by: Eddy Petrișor <eddy.petrisor@gmail.com>
---
 t/t9101-git-svn-props.sh |   24 +++++++++++++++++++++++-
 1 files changed, 23 insertions(+), 1 deletions(-)
diff --git a/t/t9101-git-svn-props.sh b/t/t9101-git-svn-props.sh
index f420796..e174b30 100755
--- a/t/t9101-git-svn-props.sh
+++ b/t/t9101-git-svn-props.sh
@@ -211,7 +211,29 @@ EOF
 
 test_expect_success 'test proplist' "
 	git-svn proplist . | cmp - prop.expect &&
-	git-svn proplist nested/directory/.keep | cmp - prop2.expect
+	git-svn proplist nested/directory/.keep | cmp - prop2.expect &&
+	cd ..
+	"
+
+test_expect_success 'show external' "
+	cd test_wc &&
+		svn mkdir zombie &&
+		svn propset svn:externals 'externaldir file:///fake/external' zombie &&
+		svn ci -m 'added a fake svn:external' &&
+	cd .. &&
+	git-svn fetch &&
+	git-merge git-svn &&
+	git-svn show-externals | grep -q 'externaldir'
+	"
+
+test_expect_failure 'remove external' "
+	cd test_wc &&
+		svn propset svn:externals '' zombie &&
+		svn ci -m 'deleted the fake external' &&
+	cd .. &&
+	git-svn fetch &&
+	git-merge git-svn &&
+	git-svn show-externals | grep -v ^# | grep -v ^$ | grep -q -v '^/zombie'
 	"
 
 test_done
-- 
1.5.6.3
Previous: Eddy PetrișorNext: Eddy Petrișor
Message 2 of 9 in “git-svn-externals PoC (in a sh script)”
  1. 0/3 git-svn-externals PoC (in a sh script)Eddy Petrișor, Aug 29, 2008
  2. git svn: should not display zombie externalsEddy Petrișor, Aug 29, 2008
  3. First crude implementation of git-svn-externalsEddy Petrișor, Aug 29, 2008
  4. added a test frame for git-svn-externals.shEddy Petrișor, Aug 29, 2008
  5. Eddy PetrișorAug 29, 2008
  6. Eric WongAug 29, 2008
  7. RFH: git-svn and submodulesEric Wong, Sep 1, 2008
  8. Eddy PetrișorSep 10, 2008
  9. Eddy PetrișorSep 10, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.