From: Eddy Petrișor Date: Fri, 29 Aug 2008 00:02:57 GMT Subject: [PATCH] git svn: should not display zombie externals Message-ID: <1219968179-14156-1-git-send-email-eddy.petrisor@gmail.com> In-Reply-To: <60381eeb0808281702q3dc7543enff2b35ebbcc80d08@mail.gmail.com> subversion does not process in any way empty svn:externals properties and doesn't list them in any way; git svn externals shouldn't do that either Signed-off-by: Eddy Petrișor --- t/t9101-git-svn-props.sh | 24 +++++++++++++++++++++++- 1 files changed, 23 insertions(+), 1 deletions(-) diff --git a/t/t9101-git-svn-props.sh b/t/t9101-git-svn-props.sh index f420796..e174b30 100755 --- a/t/t9101-git-svn-props.sh +++ b/t/t9101-git-svn-props.sh @@ -211,7 +211,29 @@ EOF test_expect_success 'test proplist' " git-svn proplist . | cmp - prop.expect && - git-svn proplist nested/directory/.keep | cmp - prop2.expect + git-svn proplist nested/directory/.keep | cmp - prop2.expect && + cd .. + " + +test_expect_success 'show external' " + cd test_wc && + svn mkdir zombie && + svn propset svn:externals 'externaldir file:///fake/external' zombie && + svn ci -m 'added a fake svn:external' && + cd .. && + git-svn fetch && + git-merge git-svn && + git-svn show-externals | grep -q 'externaldir' + " + +test_expect_failure 'remove external' " + cd test_wc && + svn propset svn:externals '' zombie && + svn ci -m 'deleted the fake external' && + cd .. && + git-svn fetch && + git-merge git-svn && + git-svn show-externals | grep -v ^# | grep -v ^$ | grep -q -v '^/zombie' " test_done -- 1.5.6.3