[PATCH] filter-branch: be more helpful when an annotated tag changes
- From
Thomas Rast <trast@student.ethz.ch>
- Date
- Aug 7, 2008, 23:50 UTC
- Message-ID
- <1218153031-18443-1-git-send-email-trast@student.ethz.ch>
- In-Reply-To
- <200808080148.27384.trast@student.ethz.ch>
Previously, git-filter-branch failed if it attempted to update an annotated tag. Now we ignore this condition if --tag-name-filter is given, so that we can later rewrite the tag. If no such option was provided, we warn the user that he might want to run with --tag-name-filter cat to achieve the intended effect.
Signed-off-by: Thomas Rast <trast@student.ethz.ch> --- git-filter-branch.sh | 14 +++++++++++--- 1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/git-filter-branch.sh b/git-filter-branch.sh index 182822a..a324cf0 100755 --- a/git-filter-branch.sh +++ b/git-filter-branch.sh @@ -361,9 +361,17 @@ do ;; $_x40) echo "Ref '$ref' was rewritten" - git update-ref -m "filter-branch: rewrite" \ - "$ref" $rewritten $sha1 || - die "Could not rewrite $ref" + if ! git update-ref -m "filter-branch: rewrite" \ + "$ref" $rewritten $sha1 2>/dev/null; then + if test $(git cat-file -t "$ref") = tag; then + if test -z "$filter_tag_name"; then + warn "WARNING: You said to rewrite tagged commits, but not the corresponding tag." + warn "WARNING: Perhaps use '--tag-name-filter cat' to rewrite the tag." + fi + else + die "Could not rewrite $ref" + fi + fi ;; *) # NEEDSWORK: possibly add -Werror, making this an error
-- 1.6.0.rc2.19.g3c9ba