git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-send-email: Do not attempt to STARTTLS more than once

From
Thomas Rast <trast@student.ethz.ch>
Date
Jul 2, 2008, 22:11 UTC
Message-ID
<1215036691-28618-1-git-send-email-trast@student.ethz.ch>

With the previous TLS patch, send-email would attempt to STARTTLS at the beginning of every mail, despite reusing the last connection. We simply skip further encryption checks after successful TLS initiation.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
 git-send-email.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index a047b01..3564419 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -772,6 +772,7 @@ X-Mailer: git-send-email $gitversion
 				if ($smtp->code == 220) {
 					$smtp = Net::SMTP::SSL->start_SSL($smtp)
 						or die "STARTTLS failed! ".$smtp->message;
+					$smtp_encryption = '';
 				} else {
 					die "Server does not support STARTTLS! ".$smtp->message;
 				}
-- 
1.5.6.1.278.g3d7f6
Message 1 of 1 in “git-send-email: Do not attempt to STARTTLS more than once”
  1. git-send-email: Do not attempt to STARTTLS more than onceThomas Rast, Jul 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.