threads / patch / 14262

patchgit-send-email: Do not attempt to STARTTLS more than once

Subject: [PATCH] git-send-email: Do not attempt to STARTTLS more than once

## tl;dr

One message between Jul 2, 2008 and Jul 2, 2008. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Thomas Rast· Jul 2, 2008, 22:11 UTC · lore

With the previous TLS patch, send-email would attempt to STARTTLS at the beginning of every mail, despite reusing the last connection. We simply skip further encryption checks after successful TLS initiation.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
 git-send-email.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to git-send-email.perl +1 −0
diff --git a/git-send-email.perl b/git-send-email.perl
index a047b01..3564419 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -772,6 +772,7 @@ X-Mailer: git-send-email $gitversion
 				if ($smtp->code == 220) {
 					$smtp = Net::SMTP::SSL->start_SSL($smtp)
 						or die "STARTTLS failed! ".$smtp->message;
+					$smtp_encryption = '';
 				} else {
 					die "Server does not support STARTTLS! ".$smtp->message;
 				}
-- 
1.5.6.1.278.g3d7f6

← back to recent threads