git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[JGIT PATCH 5/8] Correctly name the stderr redirection thread for local transport

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jul 1, 2008, 03:04 UTC
Message-ID
<1214881445-3931-6-git-send-email-spearce@spearce.org>
In-Reply-To
<1214881445-3931-5-git-send-email-spearce@spearce.org>

When we open git-receive-pack for the local transport case we still create a thread to redirect any error messages to the System.err console. In this case the thread should be named after the command we are running.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 .../org/spearce/jgit/transport/TransportLocal.java |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/TransportLocal.java b/org.spearce.jgit/src/org/spearce/jgit/transport/TransportLocal.java
index 761d1b8..b112267 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/transport/TransportLocal.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/TransportLocal.java
@@ -96,7 +96,7 @@ class TransportLocal extends PackTransport {
 		try {
 			final Process proc = Runtime.getRuntime().exec(
 					new String[] { cmd, "." }, null, remoteGitDir);
-			new StreamRewritingThread(proc.getErrorStream()).start();
+			new StreamRewritingThread(cmd, proc.getErrorStream()).start();
 			return proc;
 		} catch (IOException err) {
 			throw new TransportException(uri, err.getMessage(), err);
@@ -158,8 +158,8 @@ class TransportLocal extends PackTransport {
 	class StreamRewritingThread extends Thread {
 		private final InputStream in;
 
-		StreamRewritingThread(final InputStream in) {
-			super("JGit " + getOptionUploadPack() + " Errors");
+		StreamRewritingThread(final String cmd, final InputStream in) {
+			super("JGit " + cmd + " Errors");
 			this.in = in;
 		}
 
-- 
1.5.6.74.g8a5e
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 6 of 9 in “Minor push fixups”
  1. 0/8 Minor push fixupsShawn O. Pearce, Jul 1, 2008
  2. 1/8 Correct thin pack completion in IndexPack to handle some bundlesShawn O. Pearce, Jul 1, 2008
  3. 2/8 Delete reflog when deleting ref during dumb transport pushShawn O. Pearce, Jul 1, 2008
  4. 3/8 Refuse to create or delete funny ref names over dumb transportsShawn O. Pearce, Jul 1, 2008
  5. 4/8 Shorten progress message text from PackWriterShawn O. Pearce, Jul 1, 2008
  6. 5/8 Correctly name the stderr redirection thread for local transportShawn O. Pearce, Jul 1, 2008
  7. 6/8 Support 'git upload-pack' and 'git receive-pack' over SSHShawn O. Pearce, Jul 1, 2008
  8. 7/8 Pack jgit into a portable single file command line utilityShawn O. Pearce, Jul 1, 2008
  9. 8/8 Don't try to pack 0{40} during push of delete and updateShawn O. Pearce, Jul 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.