git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[JGIT PATCH 2/8] Delete reflog when deleting ref during dumb transport push

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jul 1, 2008, 03:03 UTC
Message-ID
<1214881445-3931-3-git-send-email-spearce@spearce.org>
In-Reply-To
<1214881445-3931-2-git-send-email-spearce@spearce.org>
If we remove a ref we must also remove the reflog.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 .../spearce/jgit/transport/WalkPushConnection.java |    7 +++++++
 .../jgit/transport/WalkRemoteObjectDatabase.java   |   13 +++++++++++++
 2 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/WalkPushConnection.java b/org.spearce.jgit/src/org/spearce/jgit/transport/WalkPushConnection.java
index f63bedd..5450b84 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/transport/WalkPushConnection.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/WalkPushConnection.java
@@ -280,6 +280,13 @@ class WalkPushConnection extends BaseConnection implements PushConnection {
 				u.setMessage(e.getMessage());
 			}
 		}
+
+		try {
+			dest.deleteRefLog(u.getRemoteName());
+		} catch (IOException e) {
+			u.setStatus(Status.REJECTED_OTHER_REASON);
+			u.setMessage(e.getMessage());
+		}
 	}
 
 	private void updateCommand(final RemoteRefUpdate u) {
diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java b/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java
index 1e13b33..b99144a 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java
@@ -269,6 +269,19 @@ abstract class WalkRemoteObjectDatabase {
 	}
 
 	/**
+	 * Delete a reflog from the remote repository.
+	 * 
+	 * @param name
+	 *            name of the ref within the ref space, for example
+	 *            <code>refs/heads/pu</code>.
+	 * @throws IOException
+	 *             deletion is not supported, or deletion failed.
+	 */
+	void deleteRefLog(final String name) throws IOException {
+		deleteFile("../logs/" + name);
+	}
+
+	/**
 	 * Overwrite (or create) a loose ref in the remote repository.
 	 * <p>
 	 * This method creates any missing parent directories, if necessary.
-- 
1.5.6.74.g8a5e
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 3 of 9 in “Minor push fixups”
  1. 0/8 Minor push fixupsShawn O. Pearce, Jul 1, 2008
  2. 1/8 Correct thin pack completion in IndexPack to handle some bundlesShawn O. Pearce, Jul 1, 2008
  3. 2/8 Delete reflog when deleting ref during dumb transport pushShawn O. Pearce, Jul 1, 2008
  4. 3/8 Refuse to create or delete funny ref names over dumb transportsShawn O. Pearce, Jul 1, 2008
  5. 4/8 Shorten progress message text from PackWriterShawn O. Pearce, Jul 1, 2008
  6. 5/8 Correctly name the stderr redirection thread for local transportShawn O. Pearce, Jul 1, 2008
  7. 6/8 Support 'git upload-pack' and 'git receive-pack' over SSHShawn O. Pearce, Jul 1, 2008
  8. 7/8 Pack jgit into a portable single file command line utilityShawn O. Pearce, Jul 1, 2008
  9. 8/8 Don't try to pack 0{40} during push of delete and updateShawn O. Pearce, Jul 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.