git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Remove dependency on IO::String from Git.pm test

From
Michael Hendricks <michael@ndrix.org>
Date
Jun 18, 2008, 13:37 UTC
Message-ID
<1213796224-995-1-git-send-email-michael@ndrix.org>

Instead of using IO::String to create an in-memory filehandle, use open() with a scalar reference as the filename. This feature has been available since Perl 5.8.0 (which was released in 2002), so it should be available pretty much everywhere by now.

Signed-off-by: Michael Hendricks <michael@ndrix.org>
---
This patch should apply on top of Junio's lw/perlish branch.
 t/t9700/test.pl |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/t/t9700/test.pl b/t/t9700/test.pl
index 8318fec..e34c01e 100755
--- a/t/t9700/test.pl
+++ b/t/t9700/test.pl
@@ -9,7 +9,6 @@ use Test::More qw(no_plan);
 use Cwd;
 use File::Basename;
 use File::Temp;
-use IO::String;
 
 BEGIN { use_ok('Git') }
 
@@ -69,20 +68,21 @@ is($r->ident_person("Name", "email", "123 +0000"), "Name <email>",
 
 # objects and hashes
 ok(our $file1hash = $r->command_oneline('rev-parse', "HEAD:file1"), "(get file hash)");
-our $iostring = IO::String->new;
+my $output;
+open our $iostring, '>', \$output;
 is($r->cat_blob($file1hash, $iostring), 15, "cat_blob: size");
-is(${$iostring->string_ref}, "changed file 1\n", "cat_blob: data");
+is($output, "changed file 1\n", "cat_blob: data");
 our $tmpfile = File::Temp->new();
-print $tmpfile ${$iostring->string_ref};
+print $tmpfile $output;
 is(Git::hash_object("blob", $tmpfile), $file1hash, "hash_object: roundtrip");
 $tmpfile = File::Temp->new();
 print $tmpfile my $test_text = "test blob, to be inserted\n";
 $tmpfile->close;
 like(our $newhash = $r->hash_and_insert_object($tmpfile), qr/[0-9a-fA-F]{40}/,
      "hash_and_insert_object: returns hash");
-$iostring = IO::String->new;
+open $iostring, '>', \$output;
 is($r->cat_blob($newhash, $iostring), length $test_text, "cat_blob: roundtrip size");
-is(${$iostring->string_ref}, $test_text, "cat_blob: roundtrip data");
+is($output, $test_text, "cat_blob: roundtrip data");
 
 # paths
 is($r->repo_path, "./.git", "repo_path");
-- 
1.5.5.23.g2a5fe
Next: Jakub Narebski
Message 1 of 10 in “Remove dependency on IO::String from Git.pm test”
  1. Remove dependency on IO::String from Git.pm testMichael Hendricks, Jun 18, 2008
  2. Jakub NarebskiJun 18, 2008
  3. Rafael Garcia-SuarezJun 18, 2008
  4. Johannes SchindelinJun 18, 2008
  5. Jakub NarebskiJun 18, 2008
  6. Johannes SchindelinJun 18, 2008
  7. Lea WiemannJun 18, 2008
  8. Junio C HamanoJun 18, 2008
  9. Johannes SchindelinJun 18, 2008
  10. Lea WiemannJun 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.