Michael HendricksInstead of using IO::String to create an in-memory filehandle, use open() with a scalar reference as the filename. This feature has been available since Perl 5.8.0 (which was released in 2002), so it should be available pretty much everywhere by now.
Signed-off-by: Michael Hendricks <michael@ndrix.org> ---
This patch should apply on top of Junio's lw/perlish branch.
t/t9700/test.pl | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
Show changes to t/t9700/test.pl +6 −6
diff --git a/t/t9700/test.pl b/t/t9700/test.pl index 8318fec..e34c01e 100755 --- a/t/t9700/test.pl +++ b/t/t9700/test.pl @@ -9,7 +9,6 @@ use Test::More qw(no_plan); use Cwd; use File::Basename; use File::Temp; -use IO::String; BEGIN { use_ok('Git') } @@ -69,20 +68,21 @@ is($r->ident_person("Name", "email", "123 +0000"), "Name <email>", # objects and hashes ok(our $file1hash = $r->command_oneline('rev-parse', "HEAD:file1"), "(get file hash)"); -our $iostring = IO::String->new; +my $output; +open our $iostring, '>', \$output; is($r->cat_blob($file1hash, $iostring), 15, "cat_blob: size"); -is(${$iostring->string_ref}, "changed file 1\n", "cat_blob: data"); +is($output, "changed file 1\n", "cat_blob: data"); our $tmpfile = File::Temp->new(); -print $tmpfile ${$iostring->string_ref}; +print $tmpfile $output; is(Git::hash_object("blob", $tmpfile), $file1hash, "hash_object: roundtrip"); $tmpfile = File::Temp->new(); print $tmpfile my $test_text = "test blob, to be inserted\n"; $tmpfile->close; like(our $newhash = $r->hash_and_insert_object($tmpfile), qr/[0-9a-fA-F]{40}/, "hash_and_insert_object: returns hash"); -$iostring = IO::String->new; +open $iostring, '>', \$output; is($r->cat_blob($newhash, $iostring), length $test_text, "cat_blob: roundtrip size"); -is(${$iostring->string_ref}, $test_text, "cat_blob: roundtrip data"); +is($output, $test_text, "cat_blob: roundtrip data"); # paths is($r->repo_path, "./.git", "repo_path");
-- 1.5.5.23.g2a5fe
