git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 7/7] pack-objects: fix early eviction for max depth delta objects

From
Nicolas Pitre <nico@cam.org>
Date
May 2, 2008, 19:11 UTC
Message-ID
<1209755511-7840-8-git-send-email-nico@cam.org>
In-Reply-To
<1209755511-7840-7-git-send-email-nico@cam.org>

The 'depth' variable doesn't reflect the actual maximum depth used when other objects already depend on the current one.

Signed-off-by: Nicolas Pitre <nico@cam.org>
---
 builtin-pack-objects.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
index f5dcd20..94c9875 100644
--- a/builtin-pack-objects.c
+++ b/builtin-pack-objects.c
@@ -1484,7 +1484,7 @@ static void find_deltas(struct object_entry **list, unsigned *list_size,
 		 * depth, leaving it in the window is pointless.  we
 		 * should evict it first.
 		 */
-		if (entry->delta && depth <= n->depth)
+		if (entry->delta && max_depth <= n->depth)
 			continue;
 
 		/*
-- 
1.5.5.1.226.g6f6e8
Previous: Nicolas PitreNext: A Large Angry SCM
Message 8 of 10 in “assorted pack-objects cleanups and improvements”
  1. 0/7 assorted pack-objects cleanups and improvementsNicolas Pitre, May 2, 2008
  2. 1/7 pack-objects: small cleanupNicolas Pitre, May 2, 2008
  3. 2/7 pack-objects: remove some double negative logicNicolas Pitre, May 2, 2008
  4. 3/7 pack-objects: simplify the condition associated with --all-progressNicolas Pitre, May 2, 2008
  5. 4/7 pack-objects: clean up write_object() a bitNicolas Pitre, May 2, 2008
  6. 5/7 pack-objects: move compression code in a separate functionNicolas Pitre, May 2, 2008
  7. 6/7 pack-objects: allow for early delta deflatingNicolas Pitre, May 2, 2008
  8. 7/7 pack-objects: fix early eviction for max depth delta objectsNicolas Pitre, May 2, 2008
  9. A Large Angry SCMMay 2, 2008
  10. Nicolas PitreMay 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.