RE: [Internet]Re: [PATCH v5 1/2] merge-tree.c: add --merge-base=<commit> option
Show 12 quoted lines
>
> > [...]
> > +test_expect_success 'specify merge-base as parent of branch2' '
> > + # Setup
> > + git init base-b2-p && (
>
> It's good practice to nuke it after the test:
>
> test_when_finished "rm -rf base-b2-p" &&
> git init base-b2-p
>
>
Thanks for the reviews, I'll fix it in the next patch.
Show 5 quoted lines
>
> Could avoid the subshell-ing with:
>
> test_commit -C base-b2-p c1 file1 &&
> [...]
kylezhao (赵柯宇) <kylezhao@tencent.com>