From: kylezhao (赵柯宇) <kylezhao@tencent.com>
Date: Thu, 03 Nov 2022 09:43:49 GMT
Subject: RE: [Internet]Re: [PATCH v5 1/2] merge-tree.c: add --merge-base=<commit> option
Message-ID: <11e8532a5ba746e2b25e689c5d1230cf@tencent.com>
In-Reply-To: <221103.868rks301x.gmgdl@evledraar.gmail.com>

> 
> > [...]
> > +test_expect_success 'specify merge-base as parent of branch2' '
> > +	# Setup
> > +	git init base-b2-p && (
> 
> It's good practice to nuke it after the test:
> 
> 	test_when_finished "rm -rf base-b2-p" &&
> 	git init base-b2-p
> 
> 

Thanks for the reviews, I'll fix it in the next patch.

> 
> Could avoid the subshell-ing with:
> 
> 	test_commit -C base-b2-p c1 file1 &&
> 	[...]

Nice.