git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add a simple option parser.

From
Kristian Høgsberg <krh@redhat.com>
Date
Oct 4, 2007, 14:57 UTC
Message-ID
<1191509878.29379.2.camel@hinata.boston.redhat.com>
In-Reply-To
<20071003231145.GF28188@artemis.corp>
On Thu, 2007-10-04 at 01:11 +0200, Pierre Habouzit wrote:
Show 19 quoted lines
> On Wed, Oct 03, 2007 at 09:45:01PM +0000, Kristian Høgsberg wrote:
> > The option parser takes argc, argv, an array of struct option
> > and a usage string.  Each of the struct option elements in the array
> > describes a valid option, its type and a pointer to the location where the
> > value is written.  The entry point is parse_options(), which scans through
> > the given argv, and matches each option there against the list of valid
> > options.  During the scan, argv is rewritten to only contain the
> > non-option command line arguments and the number of these is returned.
> 
>   if we are going in that direction (and I believe it's a good one), we
> should be sure that the model fits with other commands as well. And as I
> said on IRC, I believe the most "horrible" (as in complex) option parser
> in git is the one from git-grep.
> 
>   A migration of git-grep on that API should be tried first. If this
> works well enough, I believe that the rest of the git commands will be
> migrated easily enough. (with maybe small addition to parse-option.[hc]
> but the hardcore things should have been met with git-grep already I
> think).

I'm not sure - we can go with the current proposal and add new options types and probably the callback option type I suggested as we go. I don't want to block builtin-commit on figuring out what the perfect option parser should look like and what I sent out earlier work for commit. I think the way you handled the strbuf rewrites worked pretty well; extending and rewriting the API as you put it to use in more and more places. We can do the same thing with parse_options().

cheers, Kristian

Previous: Pierre HabouzitNext: Pierre Habouzit
Message 4 of 26 in “Add a simple option parser.”
  1. Add a simple option parser.Kristian Høgsberg, Oct 3, 2007
  2. Port builtin-add.c to use the new option parser.Kristian Høgsberg, Oct 3, 2007
  3. Pierre HabouzitOct 3, 2007
  4. Kristian HøgsbergOct 4, 2007
  5. Pierre HabouzitOct 4, 2007
  6. Pierre HabouzitOct 4, 2007
  7. Johannes SchindelinOct 4, 2007
  8. Pierre HabouzitOct 5, 2007
  9. Pierre HabouzitOct 5, 2007
  10. Add a simple option parser.Pierre Habouzit, Oct 5, 2007
  11. Mike HommeyOct 5, 2007
  12. Pierre HabouzitOct 5, 2007
  13. Medve Emilian-EMMEDVE1Oct 5, 2007
  14. Pierre HabouzitOct 5, 2007
  15. Medve Emilian-EMMEDVE1Oct 5, 2007
  16. David KastrupOct 5, 2007
  17. Pierre HabouzitOct 5, 2007
  18. Sven VerdoolaegeOct 6, 2007
  19. Linus TorvaldsOct 5, 2007
  20. Medve Emilian-EMMEDVE1Oct 5, 2007
  21. Pierre HabouzitOct 5, 2007
  22. Linus TorvaldsOct 5, 2007
  23. David KastrupOct 5, 2007
  24. Kristian HøgsbergOct 5, 2007
  25. Pierre HabouzitOct 5, 2007
  26. Pierre HabouzitOct 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.